Git Product home page Git Product logo

art's People

Contributors

hariguchi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

art's Issues

There is no API to delete the routing table and free its memory

Hi,
Thanks for this great piece of SW.
One issue we found was that there is no API to delete/free the table.
We wrote the following C++ wrapper to do the deletion/free.
It first traverse the tree and collects all entries into a vector. Then it deletes each vector element from the table. Finally, it deletes the default entry and the root elements.
Note that mTable is a pointer to rtTable.
Two questions:

  1. Can you check the code and confirm we did the right thing?
  2. Can you add such API (maybe based on our code) to the SW?
    Thanks,
    Barak

IpArtWrapper::~IpArtWrapper()
{
vector<routeEnt*> rEnts;

auto func = [](routeEnt* ent, void* p) {
    auto pv = (vector<routeEnt*>*)p;
    pv->push_back(ent);
};

rtArtWalkTable(mTable, mTable->root, 1, 1 << mTable->psi[0].sl, func, &rEnts);

for (auto ent : rEnts)
    assert(mTable->deletep(mTable, ent->dest, ent->plen));

routeEnt* defRoute = mTable->root[1].ent;
if (defRoute) {
    // delete default route manually, since rtArtWalkTable doesn't give it
    u8 dst[16] = {0};
    assert(mTable->deletep(mTable, dst, 0));
}

free(mTable->psi);
// mTable->pEnt is freed automatically when deleting routes
free(mTable->pDef);
free(mTable->pTbl);
free(mTable->pPcSt);
free(mTable->root + mTable->off);
free(mTable);

}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.