• populate [files] in package.json. Delete .npmignore.
• automated code linting. #3308
  • dep: eslint-plugin-haraka -> @haraka/eslint-config
  • update 'lint' script in package.json
  • verify 'lint' CI test config
• lint: remove duplicate / stale rules from .eslintrc
• automated code formatting (see also #3308)
• automated CI testing.
  • mostly done, verify that local copy of ci.yml is up-to-date.
• CONTRIBUTORS: see 3309
• consistent naming of "special" files like CHANGELOG.md.
• CHANGELOG: verify links at bottom (due to inconsistent tag naming)
  • latest .release does this, fixes most, and warns of errors it can't fix
• verify GitHub repo About link points to npm package
• convert test suites to mocha "style"
  • works great today and with node --test in v18+

When trying to pipe the connection.transaction.message_stream to a target stream more than once, an error is thrown.

Example code in a queue plugin (without error handling for simplicity):

// in any plugin, possibly multiple times:
var txn = connection.transaction;
['/tmp/test-a', '/tmp/test-b', '/tmp/test-c'].forEach(file =>
{
    txn.message_stream.pipe(fs.createWriteStream(file));
    txn.message_stream.pause();
}

// finally, in the queue plugin:
txn.message_stream.resume();

This throws an error "Cannot pipe while currently piping". Browsing the code, it looks like this message_stream cannot be used in place of any regular readable stream?

The first idea for a workaround would be to listen to 'data', 'error', and 'end' events, instead of using the message_stream.pipe() function. But that does not work out of the box either, I've tried multiple ways, but it only got me in a deeper mess.

Currently, I am using the following workaround instead (with error handling):

var txn = connection.transaction;
var multistream = txn.notes.message_stream || (txn.notes.message_stream = new stream.PassThrough());
['/tmp/test-a', '/tmp/test-b', '/tmp/test-c'].forEach(file =>
{
    var target = fs.createWriteStream(file);
    target.on('error', err => { throw err; });
    multistream.on('error', err => target.destroy(err));
    multistream.pipe(target);
});

await new Promise((resolve, reject) =>
{
    multistream.on('error', reject);
    multistream.on('finish', resolve);
    
    txn.message_stream.on('error', err => multistream.destroy(err));
    txn.message_stream.pipe(multistream);
});