haraka / haraka-net-utils Goto Github PK

update the docs for get_mx and get_ips_by_host to show async/await usage (vs callback).

openssl-wrapper is currently a dependency in this package. As part of the TLS revamping project I moved all the TLS functions out of this package and into Haraka/tls_socket.js. Unfortunately, I didn't move the openssl-wrapper dependency to Haraka's package.json. It worked fine because this is a Haraka dep but now there are published versions of Haraka that won't work unless openssl-wrapper is included in this package. I haven't thought of a "doesn't hurt someone" solution.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

A STUN timeout does not end the test if Stun is not installed and running.

This is a fresh install of Haraka on Debian 11. Stun is not installed.

With this command, I get four errors
# time npm test

  103 passing (8s)
  4 failing

  1) is_local_host
       127.0.0.1:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/etc/haraka/node_modules/haraka-net-utils/test/net_utils.js)
      at listOnTimeout (node:internal/timers:573:17)
      at process.processTimers (node:internal/timers:514:7)

  2) is_local_host
       self ip:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/etc/haraka/node_modules/haraka-net-utils/test/net_utils.js)
      at listOnTimeout (node:internal/timers:573:17)
      at process.processTimers (node:internal/timers:514:7)

  3) get_public_ip
       normal:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/etc/haraka/node_modules/haraka-net-utils/test/net_utils.js)
      at listOnTimeout (node:internal/timers:573:17)
      at process.processTimers (node:internal/timers:514:7)

  4) get_public_ip_async
       normal:
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/etc/haraka/node_modules/haraka-net-utils/test/net_utils.js)
      at listOnTimeout (node:internal/timers:573:17)
      at process.processTimers (node:internal/timers:514:7)

After 10 seconds I get three STUN timeouts:

Error: STUN timeout
    at Timeout._onTimeout (/etc/haraka/node_modules/haraka-net-utils/index.js:327:15)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7)
Error: timeout
    at Timeout.<anonymous> (/etc/haraka/node_modules/haraka-net-utils/node_modules/@msimerson/stun/src/net/request.js:181:38)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7)
Error: timeout
    at Timeout.<anonymous> (/etc/haraka/node_modules/haraka-net-utils/node_modules/@msimerson/stun/src/net/request.js:181:38)
    at listOnTimeout (node:internal/timers:573:17)
    at process.processTimers (node:internal/timers:514:7)

After another 60 seconds the test run completes.

real	1m10.865s
user	0m1.801s
sys	0m0.358s

After installing and running stun, the tests run successfully.

• depends on Haraka 2.8.15 release.

• populate [files] in package.json. Delete .npmignore.
• automated code linting. #3308
  • dep: eslint-plugin-haraka -> @haraka/eslint-config
  • update 'lint' script in package.json
  • verify 'lint' CI test config
• lint: remove duplicate / stale rules from .eslintrc
• automated code formatting (see also #3308)
• automated CI testing.
  • mostly done, verify that local copy of ci.yml is up-to-date.
• CONTRIBUTORS: see 3309
• consistent naming of "special" files like CHANGELOG.md.
• CHANGELOG: verify links at bottom (due to inconsistent tag naming)
  • latest .release does this, fixes most, and warns of errors it can't fix
• verify GitHub repo About link points to npm package
• convert test suites to mocha "style"
  • works great today and with node --test in v18+

Reported by EyePulp on IRC:

2018-01-25T21:34:36.566Z :: [CRIT] [-] [core] TypeError: net_utils.tls_ini_section_with_defaults is not a function
2018-01-25T21:34:36.567Z :: [CRIT] [-] [core] at Object.exports.get_tls_options (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/outbound/tls.js:10:35)
2018-01-25T21:34:36.568Z :: [CRIT] [-] [core] at pluggableStream. (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/outbound/hmail.js:774:51)
2018-01-25T21:34:36.569Z :: [CRIT] [-] [core] at emitOne (events.js:96:13)
2018-01-25T21:34:36.572Z :: [CRIT] [-] [core] at pluggableStream.emit (events.js:188:7)
2018-01-25T21:34:36.572Z :: [CRIT] [-] [core] at pluggableStream.socket.process_data (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/line_socket.js:24:20)
2018-01-25T21:34:36.573Z :: [CRIT] [-] [core] at pluggableStream. (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/line_socket.js:35:48)
2018-01-25T21:34:36.573Z :: [CRIT] [-] [core] at emitOne (events.js:96:13)
2018-01-25T21:34:36.573Z :: [CRIT] [-] [core] at pluggableStream.emit (events.js:188:7)
2018-01-25T21:34:36.574Z :: [CRIT] [-] [core] at Socket. (/var/projects/kaczynski/bin/haraka_installer/node_modules/Haraka/tls_socket.js:57:14)
2018-01-25T21:34:36.575Z :: [CRIT] [-] [core] at emitOne (events.js:96:13)

Because Haraka's package.json contains:

"dependencies": {
"haraka-net-utils" : ">=1.0.10",
},

And e1c8e8b breaks it.

Maybe we should pin versions for release in future to prevent things like this from happening?

Cc: @baudehlo

At least I assume it was an accident: https://github.com/haraka/haraka-net-utils/blob/master/index.js#L167

After upgrading to the Haraka 2.8.24, haraka-plugin-geoip is now logging this error, "no GeoIP results for local_ip!"
I tracked it down to get_geoip() which calls net_utils.is_private_ip(), which calls net_utils.is_local_ip(), which returns true for my server's public IP address.

Hi guys, I want to use the list of the local ips in some conditions inside a plugin that using the 'send_email' hook, is there any defined constant contain this info?

I could get the addresses using several ways, e.g :

var localAddresses = function(){
        var os = require('os');

        var interfaces = os.networkInterfaces();
        var addresses = [];
        for (var k in interfaces) {
            for (var k2 in interfaces[k]) {
                var address = interfaces[k][k2];
                if (address.family === 'IPv4' && !address.internal) {
                    addresses.push(address.address);
               	}
            }
        }

        return addresses;
}

But I think it will be better do define the list elsewhere so we don't have to retrieve the ips in every call of the plugin. (Define a global variable when the sever starting up for example).

If there's no variable contain this information, I'm not sure if the 'haraka-net-utils' is the right place to add this function.

I've tracked down bug which hit me during dev

2024-04-19T13:12:58.833Z [DEBUG] [mail_from.is_resolvable] a.cz: MX 0 185.59.2.14 => queryAaaa ENOTFOUND 185.59.2.14
2024-04-19T13:12:58.833Z [INFO] [core] hook=mail plugin=mail_from.is_resolvable function=hook_mail params=<[email protected]> retval=DENY msg="MX without A/AAAA records"

Origin source is https://github.com/haraka/Haraka/blob/db8dbfa5cdce7fef3f6d39b1abf5c3a3f8aba60f/plugins/mail_from.is_resolvable.js#L107 - get_ips_by_host generate exactly two errors

• queryA ENOTFOUND 185.59.2.14
• queryAaaa ENOTFOUND 185.59.2.14

It seems that IP detection is missing somewhere