Git Product home page Git Product logo

Comments (12)

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

Hi @mass4441

Thank you for reporting this. Can you please send a code demo where the issue is replicable? I checked the changes between 14.0 and 14.1, and I don't see anything that might cause this, so I need to see your implementation to determine what is causing the problem.

from handsontable.

mass4441 avatar mass4441 commented on June 25, 2024

Hello @adrianszymanski89

i tried to reproduce this behaviour in a fresh repo with Vue 3 and Handsontable 14.1.0 but it's working as expected.
The bug is only reproducted in our main project but the structure is way more complexe and realy hard to reproduce in a fresh repo.

But the issues seems to only affect the className meta and not the others ( we have multiple dynamic readonly on cells and it work properly ).

While typing this message i tried handsontable 14.1.0 with "@handsontable/vue3": "14.0.0" and now it's working.
Seems this commit is creating the bug: (e2b07e5)

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

Hi @mass4441

If it works correctly on a fresh project, it should also work in your environment. I looked at the PR you mentioned, and it doesn't look like it would be the reason.

Did you try to do the fresh install of Handsontable in your project and delete node modules?

from handsontable.

mass4441 avatar mass4441 commented on June 25, 2024

Just tried to delete node_modules but still the same issue.

Only way to make it work is to use "handsontable": "14.1.0" and "@handsontable/vue3": "14.0.0".

Not sure if this help but after retrieving our datas from API with pass it to the HotTable component by updating the hotSettings object like this :

Template component :

<HotTable
            v-if="datas.length > 0"
            :settings="hotSettings"
        />

Inside props watcher :

this.hotSettings.data = newHotSettingsData;

I'll try again to reproduce this issue and let you know when i find why with version 14.1.0 my code is not working anymore.

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

@mass4441

I'll be grateful for this, as that would help us narrow down the possible source of this issue. Still, it seems unlikely that something would work that differently in a developed and clean project.

from handsontable.

mass4441 avatar mass4441 commented on June 25, 2024

@adrianszymanski89

I finaly found a way to reproduce the issue in a new project.

This project https://github.com/mass4441/handsontable-bug reproduce the bug.

As you can see with handsontable 14.0.0 it's working (the color red (className) persist even if you update the data ) but as soon as you update to 14.1.0 it remove the class and we lose the color. (Same issue if we update data with the table directly and not the button)

But if you don't set custom "columns" array in hotSetting then it's working in 14.1.0.

Am i doing something wrong ? Or is it an issue with 14.1.0 ?

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

Hi @mass4441

Thank you for the code. So far, I haven't been able to narrow down which change in 14.1.0 might be causing this. I will investigate it further and will update you soon.

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

Hi @mass4441

I was able to reproduce this issue here: https://jsfiddle.net/handsoncode/6n51o9r0/1/ Indeed, it seems that defining the columns is responsible for this bug, but the thing I've found is that this issue was present all the time, not only in 14.1.0.

However, we have a similar issue reported internally, and it surely needs to be investigated more by our developers.

I will update you once we have any progress on this. So far, I haven't been able to find any workaround for this besides not defining the columns, but I know that it's not the best way to avoid it.

from handsontable.

mass4441 avatar mass4441 commented on June 25, 2024

Hello @adrianszymanski89,

thanks for your feedback.

Is it possible that it was working for us because we directly update the array hotSetting.data and we don't use setDataAtCell ?

Btw, updating hotSettings.data is a correct way to do ? Or should we avoid it and only use provided function (loadData, updateData, setData, ... ). ?

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

@mass4441

Yes, that's what I also suspected, and we recommend using our dedicated methods to update the data.

from handsontable.

mass4441 avatar mass4441 commented on June 25, 2024

Hello @adrianszymanski89 ,

any update on this ? Do you think it will be fixed in the next release ?

Thansk !

from handsontable.

adrianszymanski89 avatar adrianszymanski89 commented on June 25, 2024

Hi @mass4441

It's not on our roadmap yet. We'll update this thread once it gets there.

from handsontable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.