Git Product home page Git Product logo

Comments (16)

AMBudnik avatar AMBudnik commented on May 25, 2024

Hi @pinuchfab

We do our own performance testing with each version to make sure that there is no degradation. It may happen for some plugins' sets that we do not use. But I would need to have a demo to replicate the issue (especially as you mentioned eco-renderers that we do not have).

from handsontable.

pinuchfab avatar pinuchfab commented on May 25, 2024

Hello, thanks for quick reply, I have asked the team to use 12.4 as this is the most reliable release so far post 8.1, I had to make a couple of small changes but overall I am happy with it. I will setup a demo after the holiday, I just wanted to start the chat really. Another problem I found is that once the columns are set using updateSettings, then if columns are moved using the column move plugin, it is then not possible to set the original columns back with updateSettings anymore, even so the right order of columns is passed, this was working in 8.1, not working anymore in 12.4, not a major problem, but we would need to find a workaround. I might log a separate defect for this.

from handsontable.

AMBudnik avatar AMBudnik commented on May 25, 2024

If you like the v12.4.0 version, then I think that there is something particular in the settings/plugins that is set to be slower in v13. We have reported that there is a performance drop for merge cells, but that happened for the v12.0 (versus the older version). So, without a demo it will be hard to say anything here. Still, please take your time and enjoy the holiday.

When it comes to the manualColumnMove, I would need to create a step-by-step scenario to replicate the issue. And in 14.2.0 we even added an ability to undo the move action for columns (via this PR #10746).

I will keep this issue open. Please contact me after the holiday.

from handsontable.

pinuchfab avatar pinuchfab commented on May 25, 2024

Hello, I am now back.
So here are the steps to try on your side using 12.4.0:
-> create a table with 10 columns ([ A, B, C, D .. ] as an example)
-> have a button on the UI that when clicked on it will run that code:
btnClickCb = () => {

          const newColumnsToSetInHot = [ A, B, C, D .. ];  // Essentially reconfigure columns as they were before the move.
          myHotInstance.updateSettings({ columns: newColumnsToSetInHot }, false); // true or false makes no difference.

}
-> manually move second column to third position (drag)
so we will end up with [ A, C, B, D, ...] shown in the UI.
-> click on button to reset columns order to be [ A, B, C, D, ...]

Expected: [ A, B, C, D ]
Results: [ A, C, B, D ]

Obviously this is a simplification of the code, but this behavior used to work with 8.1.

On another note, the business has asked us in the case we stick with 12.4.0, which we want to as 14.0 was not good for us, how long do you plan to support 12.4.0 in case we have security issues being identified, even so we have not had any. Finally, are you aware of any security issue related to 12.4.0.

Thanks so much for your help.

from handsontable.

pinuchfab avatar pinuchfab commented on May 25, 2024

I would like to mention we don't find any values (for our business) to undoing or redoing column dragging, we are only using undo/redo for cell/row modifications (editing vs preferences), not for columns moving, which will actually be a problem as we consider columns ordering as part of user's preference that should not be mixed with editing, this could actually be really frustrating for a user to lose their columns ordering when they undo or redo their changes if they did change that preference between two edits of a cell for instance... I hope this is optional. Thanks.

from handsontable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.