haacked / encourage Goto Github PK

Trying to install the latest version 1.1.2 and get the following error:

The extension could not be installed because the following error occurred:

This extension is not support on the current product.

Encourage works perfectly with Visual Studio 2013 when I use "Save" (or hit Ctrl+S) but it doesn't seem to work when I use "Save All" (or hit Ctrl+Shift+S).

There is a problem while formatting (indenting, adding/erasing whitespaces and/or newlines, etc.) directives such as #endregion, #pragma, etc..

The problem lies within the following classes/functions:

• SyntaxFormatter
• NormalizeWhitespaceCore
• NormalizeWhitespace

These functions are inconsistent with the CSharp compiler, which allows lines such as:

#endregion foo

where the conventional way of doing this is:

#endregion //foo

The formatting erases the whitespace after the directive, giving a non-compilable file like this:

#endregionfoo <--- here, having written "#endregion //foo" wouldn´t cause any problem, because one would be getting a compilable "#endregion//foo"

Similar problem with #pragma, where an extra enter is erased while formatting the following:

#pragma warning disable 123

namespace foo {
}

#pragma warning restore 123

one gets the following non-compilable code:

#pragma warning disable 123
namespace foo {
}#pragma warning restore 123  <--- extra enter erased here, after the closing bracket

Sample repro for the #pragma issue:

using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.Formatting;
using static System.Console;
class Program
{
    static void Main(string[] args)
    {
        var tree = SyntaxFactory.ParseSyntaxTree(@"
            #pragma warning disable 123
            namespace foo {
            }
            #pragma warning restore 123
            ");
        WriteLine("NormalizeWhitespace()");
        WriteLine("=====================");
        WriteLine(tree.GetRoot().NormalizeWhitespace().ToFullString());
        WriteLine();
        WriteLine("Formatter.Format()");
        WriteLine("=====================");
        WriteLine(Formatter.Format(tree.GetRoot(), new AdhocWorkspace()).ToFullString());
    }
}

When I start typing in an empty immediate window (while debugging) or use "clear all", encouragements pop up all the time.

It just doesn''t show anymore

Curious if you'd want something like this - I started to add it with the other PR but then realized that was a bad idea :)

I have some pre-existing art for doing it if interested.

While working I get a random error, so far I couldn't figure out a scenario, here is the error window I get:

The log has the following entry for the error:

I hope this is enough to figure out the problem.

This VSIX doesn't have an icon displayed in the marketplace. The icon should be 90x90.

The icon is added to the metadata section of the vsixmanifest, here is the line from the NUnit adapter,

<Icon>nunit_90.png</Icon>

In the CSPROJ, the icon should be set to IncludeInVsix=true

You can set a 200x200 preview image the same way, but it isn't displayed in VS2017 anymore, just previous versions.

Any ideas for an icon? Speech bubble with an exclamation point?

Have a solution but checking up on one of the assumptions I made before publishing it.

I saw the closed ticket: #40 and it was closed because someone didn't want to test with resharper. I can confirm that with resharper ultimate that it does not work on files like .cs or .cshtml. I did notice that it worked in a web.config file however. I am also using visual studio 2017 15.7.4 on windows 10 and resharper JetBrains ReSharper Ultimate 2018.1.2 Build 112.0.20180530.113618

I would be interested in investigating this further!

Would be nice to be able to have a centralised encouragement list for use between multiple developers.

One of my "discouragements" has the word this in it

when shown on top of a C# file, the discouragement seemed to have syntax highlighting. To confirm, I replaced my list of encouragements with nonsense that would syntax highlight

and they as well seem to syntax highlight.

Is this by design?

Using VS 2013, I open a new query window from a Server Explorer data connection. When I execute the query, an encouragement is briefly displayed in the Message tab as the query is executed.

Would love to see this for Visual Studio 2022. Currently it won't let me install to it.

When editing and saving a js file, encouragements appear in the same popup thingy as the one used by IntelliSense to display information. When this happens, they are also positioned incorrectly.

Here is a screenshot: http://venemo.net/owncloud/public.php?service=files&t=b09df56aed84f5ebeeb93d1195199ec6

When that thingy pops up, you can only see the encouragement by either clicking on the arrows on it, or by hitting the up/down arrow keys.

Hey @jaredpar, I hope you don't mind another VS question. I'm trying to write a stupid silly extension that will show a tool tip wherever the cursor is when you save your document.

Seems pretty simple, eh?

I thought I'd try to leverage the QuickInfo stuff because it provides the right tooltip behavior. But I can't seem to trigger it programmatically on save. Also, it seems intrinsically tied to mouse hover.

Am I going about this totally wrong? Got any suggestions for how I should be doing this?

The RC and RTM releases of Visual Studio require v3 VSIX format, so the previous changes to enable support no longer work. The following is the screenshot from the marketplace,

Converting the VSIX to v3 format is easy, add Prerequisites,

<Prerequisites>
  <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[15.0.25904.2,16.0)" DisplayName="Visual Studio core editor" />
</Prerequisites>

This allows Visual Studio to install missing components if required. This extension likely doesn't need much more than the shell/core editor, so the code above is fine.

When you get the list of overloads of a method, an extra overload is displayed with the encouragement.

VS 2017 Enterprise (ver 15.4.4)
Error and log for it attached

27.11.2017 18:33:33 - Microsoft VSIX Installer
27.11.2017 18:33:33 - -------------------------------------------
27.11.2017 18:33:33 - Initializing Install...
27.11.2017 18:33:33 - Extension Details...
27.11.2017 18:33:33 - Identifier : f38d29e7-cd86-43d5-9c32-4be26302b55e
27.11.2017 18:33:33 - Name : Encourage
27.11.2017 18:33:33 - Author : Phil Haack
27.11.2017 18:33:33 - Version : 1.2.1
27.11.2017 18:33:33 - Description : Adds a bit of whimsy to your work day.
27.11.2017 18:33:33 - Locale : en-US
27.11.2017 18:33:33 - MoreInfoURL : https://github.com/haacked/encourage
27.11.2017 18:33:33 - InstalledByMSI : False
27.11.2017 18:33:33 - SupportedFrameworkVersionRange : [4.5,)
27.11.2017 18:33:33 -
27.11.2017 18:33:33 - Supported Products :
27.11.2017 18:33:33 - Microsoft.VisualStudio.Community
27.11.2017 18:33:33 - Version : [11.0,15.0]
27.11.2017 18:33:33 -
27.11.2017 18:33:33 - References :
27.11.2017 18:33:33 - -------------------------------------------------------
27.11.2017 18:33:33 - Identifier : Microsoft.VisualStudio.MPF.11.0
27.11.2017 18:33:33 - Name : Visual Studio MPF 11.0
27.11.2017 18:33:33 - Version : [11.0]
27.11.2017 18:33:33 - MoreInfoURL :
27.11.2017 18:33:33 - Nested : No
27.11.2017 18:33:33 -
27.11.2017 18:33:33 -
27.11.2017 18:33:33 - Searching for applicable products...
27.11.2017 18:33:33 - Found installed product - Global Location
27.11.2017 18:33:33 - Found installed product - ssms
27.11.2017 18:33:33 - VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.
в VSIXInstaller.App.InitializeInstall(Boolean isRepairSupported)
в VSIXInstaller.App.InitializeInstall()
в System.Threading.Tasks.Task.InnerInvoke()
в System.Threading.Tasks.Task.Execute()

Encourage, what a sweet extension.
Tried to install on 'Microsoft Visual Studio Ultimate 2013'. Got 'VSIXInstaller.NoApplicableSKUsException'.
The logfile explains that supported products are 'Microsoft.VisualStudio.Community [11.0,15.0]', and thus I am out of luck. Is this by design or would you be willing to fix this? Thank so much in advance! Way to go!! :)

VSIXInstaller_log.txt

I have two monitors. Sometimes I tear out a tab from the main window Visual Studio and put it on the other monitor. When I do this and hit save in the main window, the encouragement appears on the other monitor.

Note: I could reproduce this with both cs and js files.

To start, I think we'd implement a simple property window with a text area and each encouragement goes on its own line.

@jaredpar do you have pointers for how to do this quickly and easily?