h-kanazawa / react-detectable-overflow Goto Github PK

Hi, I found a problem with false detection on Chrome (version 91.0.4472.124).
When I zoom out to 90% on a Demo, component triggers as overflowed.

I was trying to debug a problem, looks like bad rounding -> scrollWidth is smaller than offsetWidth. I changed a state detection like this and it seems to work fine for my case but don't know if its a right solution.
const newState = this.ref.current.offsetWidth < this.ref.current.scrollWidth || this.ref.current.offsetHeight < this.ref.current.scrollHeight;

add the ability to trigger overflow 1 time so that when resizing it does not trigger again, I need to detect overflow 1 time

I have a table in an absolutely positioned div and the div is set to overflow-y. The vertical scroll bar on the div appears when the table is too long for the div.

Do I wrap the div in DetectableOverflow or should I replace the div with DetectableOverflow?

Either way I'm getting no output from the component.

Hi there!

I've noticed this warning in the console while using react-detectable-overflow:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of ChildWrapper which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

This is actually a warning shown from the package react-resize-detector that this library uses. As stated in the README, a ref is needed to not use the deprecated findDOMNode.

I believe that a ref is needed in the children that is received and then passed using targetRef to the ReactResizeDetector component over here:

Am I right? I'm fine with submitting a PR with this fix.

By the way, thank you for this great library!