gustavohenke / mockbase Goto Github PK

https://firebase.google.com/docs/reference/js/firebase.firestore.CollectionReference#orderBy

It would be great if a Mock Sign In could be used more then once. In testing frameworks like jest there are methods that allow mocking only once and mocking more then once and having similar functionality with this library.

https://firebase.google.com/docs/reference/js/firebase.firestore.CollectionReference#onSnapshot

https://firebase.google.com/docs/reference/js/firebase.auth.Auth#signOut

https://firebase.google.com/docs/reference/js/firebase.firestore.CollectionReference#where

https://firebase.google.com/docs/reference/js/firebase.firestore.DocumentReference#update

Code in question:

Example on how it is used from firebase in AngularFire

  return new Observable(subscriber => {
    let unsubscribe;
    if (scheduler != null) {
      scheduler.schedule(() => {
        unsubscribe = ref.onSnapshot(subscriber);
      });
    } else {
      unsubscribe = ref.onSnapshot(subscriber);
    }

    return () => {
      if (unsubscribe != null) {
        unsubscribe();
      }
    };
  });

By destructuring the subscriber it results in this error.

Unhandled Promise rejection: Cannot read property 'isStopped' of undefined ; Zone: ProxyZone ; Task: Promise.then ; Value: TypeError: Cannot read property 'isStopped' of undefined

Because next() references this internally in the RxJS subscriber it needs to be called with dot notation of the subscriber.

https://firebase.google.com/docs/reference/js/firebase.auth.Auth#signInWithEmailAndPassword

https://firebase.google.com/docs/reference/js/firebase.firestore.DocumentReference#get

https://firebase.google.com/docs/reference/js/firebase.firestore.DocumentReference#onSnapshot

First I would like to thank you Gustavo for all the hard work you have put into mocking Firebase.
I have been attempting to build out proper unit test when using Angular Fire and your mock of Firebase has been instrumental in building out proper mocks.

I am running into an issue with your mock of Firestore though. That is that it is only sending me the added docs but not removed or modified.

This is the section of code that I am getting stuck and and not getting past the short circuit.

This is where the lastSnapshot seems like it should be set to prevent that short circuit

Code I am using

      const subject = new Subject();
      this.app
        .firestore()
        .collection(path)
        .onSnapshot({
          next: (collection) => {
            subject.next(
              collection.docChanges().map(({ type, doc }) => ({ type, payload: { doc } }))
            );
          },
          error: (err) => subject.error(err),
          complete: () => subject.complete(),
        });

      subject.subscribe(console.log);

I have played around with it for a bit but can't seem to figure out the exact cause. My guess is either (a) lastSnapshot isn't being set OR (b) the current snapshot and lastSnapshot are always in sync, or at least at the time when docChanges() runs from within a onSnapshot()

Again thank you so much for your work. Let me know if you need any more information or have any work arounds.

auth/email-already-in-use
Thrown if there already exists an account with the given email address.

https://firebase.google.com/docs/reference/js/firebase.auth.Auth#createUserWithEmailAndPassword

In some libraries it is assumed that UserCredential will include additionalUserInfo. While the typing of UserCredential is clear that additionalUserInfo can be null or undefined many libraries assume that if the sign in came from a supported platform (like Google) then the additionalUserInfo will be included.

For example:
https://github.com/dappsnation/akita-ng-fire/blob/b698cfcdd5e9e21f59aa8e5a4126d41d529a760f/projects/akita-ng-fire/src/lib/auth/auth.service.ts#L255-L295

Additionally libraries, including this one, may have branching behavior based on what is included in additionalUserInfo so being able to express this when setting up the mock would allow for testing that additional behavior.

https://firebase.google.com/docs/reference/js/firebase.firestore.CollectionReference#limit

https://firebase.google.com/docs/reference/js/firebase.auth.Auth#signInWithPopup
https://firebase.google.com/docs/reference/js/firebase.auth.Auth#signInWithRedirect

Implement features around user linking:

• https://firebase.google.com/docs/reference/js/firebase.auth.Auth#fetchsigninmethodsforemail
• https://firebase.google.com/docs/reference/js/firebase.User#linkwithpopup
• https://firebase.google.com/docs/reference/js/firebase.User#linkwithredirect
• https://firebase.google.com/docs/reference/js/firebase.User#unlink

In this section

When used with

  public readonly authState = new Observable<User | null>(
    this.auth.onAuthStateChanged.bind(this.auth)
  );

as done in
https://github.com/angular/angularfire/blob/2de8501d10add9e575885db9f44b8098e5857929/src/auth/auth.ts#L66

throws the following error.

TypeError: nextOrObserver is not a function

It should be noted that nextOrObserver is a SwitchMapSubscriber when this error occurs.

Reference:
https://github.com/ReactiveX/rxjs/blob/b8c2a52bf78e855dfe48e3620b7ee2fee05ec120/src/internal/operators/switchMap.ts#L109

Simply checking typeof should allow us to determine if nextOrObserver is next or observer
observer seem to be expecting you to call nest() on them with the user.

Here is the firebase implementation of this function for additional reference
https://github.com/firebase/firebase-js-sdk/blob/35bc0a2eea98d9796023f15cd5783700d45ccc4d/packages/auth/src/auth.js#L1442-L1472

https://firebase.google.com/docs/reference/js/firebase.auth.Auth#onAuthStateChanged