gsg-g7 / baraka-v2 Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 1.0 2.09 MB

Home Page: https://barakav2.herokuapp.com

CSS 14.49% JavaScript 69.10% HTML 14.82% PLpgSQL 1.58%

baraka-v2's People

Contributors

Stargazers

Watchers

Forkers

maiubeid

baraka-v2's Issues

create connection js file for DB

Select after insert

Baraka-V2/test/db.test.js

Lines 89 to 92 in e286244

	dbBuild()
	.then(() => user.insert({ username: 'kalb', password: 1, email: '[email protected]' }))
	.then(() => user.selectAll())
	.then(res => res.rows)

You don't need to make a select query after the insert.
the insert query already gives you the ability to return what you insert.
you just need to add the ( RETURNING * ) word at the end of the SQL query.

So Clean!

It felt so good reading your code! Other than the few minor issues I pointed out, everything was so nice and clean! Keep it up :D

Create database schema

Create database schema with the proper data

express json

Baraka-V2/src/app.js

Line 12 in e286244

app.use(express.json());

why do you need this line ??

marge all tests file to one index file

status code

Baraka-V2/src/controllers/signup.js

Lines 20 to 22 in e286244

 if (err.isJoi) res.send(errmsg(err.details[0].type)); 

 else if (err.message === 'username exists') res.send(errmsg(err.message)); 

 else next(err);

where is the status code?!

Validation

client side validation using html5 required attribute
server side using @hapi/joi:
- username: has to be string, and unique(done with assist of db, not associated with joi)
- password: string, min 8 characters long, max 30 or whatever
- confirmPassword
- email: string email, 2 mail segments

Eslint

Baraka-V2/package.json

Lines 23 to 28 in e286244

 "eslint": "^6.1.0", 

 "eslint-config-airbnb": "^18.0.1", 

 "eslint-config-airbnb-base": "^14.0.0", 

 "eslint-config-prettier": "^6.1.0", 

 "eslint-plugin-import": "^2.18.2", 

 "eslint-plugin-prettier": "^3.1.0",

you install more than eslint configurations, you should use just one.

Follow the Convention

Baraka-V2/src/models/queries/item.js

Line 18 in e286244

text: 'update baraka_item set is_done = true where id = $1',

Sometimes you did, sometimes you didn't. Make sure you always UPPERCASE your SQL keywords.

insert queries

write tests that insert before! Hint: use the commented tests
insert queries and get all into the following tables:

baraka_user
baraka_list
baraka_item

create insert_fake_data.sql

Unused package

Baraka-V2/package.json

Line 39 in e286244

"compression": "^1.7.4",

next syntax

Baraka-V2/src/controllers/login.js

Line 26 in e286244

.catch(next);

Hi :)
Very good code, I just have a note here about next function it takes the error parameter
.catch(error => next(error))

hashing passwords

make a function for hashing passwords with salt using bcrypt module not bcryptjs

Fake data

Baraka-V2/test/db.test.js

Lines 11 to 27 in e286244

	const expected = [
	{ id: 1, username: 'mohammed', password: 'password1', email: '[email protected]' },
	{ id: 2, username: 'fadi', password: '1', email: '[email protected]' },
	{ id: 3, username: 'mai', password: '1', email: '[email protected]' },
	{ id: 4, username: 'amooda', password: '1', email: '[email protected]' }
	];
	dbBuild()
	.then(() => user.selectAll())
	.then(res => res.rows)
	.then(res => {
	t.deepEqual(res, expected, 'the table of user should contain four user');
	t.deepEqual(
	Object.keys(res[0]),
	['id', 'username', 'password', 'email'],
	' the keys of first user object should return id and name'
	);
	t.equal(res[0].id, 1, 'the first id in the user is 1');

The test for the keys in the query result is enough to make sure the query is running correctly, you don't need to test the value of keys

Test script

Baraka-V2/package.json

Line 12 in e286244

 "test": "NODE_ENV=test node test/logic.test.js | tap-spec && NODE_ENV=test node test/routes.test.js | tap-spec && NODE_ENV=test node test/db.test.js | tap-spec && NODE_ENV=test node test/validate.test.js | tap-spec", 

import all of your test files in one file and then run this file in the script.

id
username
isLogged

 ); 

 t.equal(res[0].id, 1, 'the first id in the user is 1'); 

 t.equal(res[1].username, 'fadi', 'the last name in the user is Fadi'); 

 }) 

 .then(t.end) 

 .catch(t.error);

Just add the t.end after the t.equal, you don't need to add new .then()

 );
      t.equal(res[0].id, 1, 'the first id in the user is 1');
      t.equal(res[1].username, 'fadi', 'the last name in the user is Fadi');
      t.end();
    })
    .catch(t.error);

	if (err.isJoi) res.send(errmsg(err.details[0].type));
	else if (err.message === 'username exists') res.send(errmsg(err.message));
	else next(err);

	"eslint": "^6.1.0",
	"eslint-config-airbnb": "^18.0.1",
	"eslint-config-airbnb-base": "^14.0.0",
	"eslint-config-prettier": "^6.1.0",
	"eslint-plugin-import": "^2.18.2",
	"eslint-plugin-prettier": "^3.1.0",

	);
	t.equal(res[0].id, 1, 'the first id in the user is 1');
	t.equal(res[1].username, 'fadi', 'the last name in the user is Fadi');
	})
	.then(t.end)
	.catch(t.error);

gsg-g7 / baraka-v2 Goto Github PK

baraka-v2's People

Contributors

Stargazers

Watchers

Forkers

baraka-v2's Issues

Recommend Projects

Recommend Topics

Recommend Org