gsg-g7 / amai-todo-list Goto Github PK

relates #16

do tests and code separately of todoFunctions.markTodo

to avoid get element two times, in the first get just get the element and then check value and reset it as you want

let inputText = document.querySelector('input[name=description]')

this one will tell the render how to show the <li> items
and add buttons to it, add event listeners to them.
and make it work with addTodoForm

code and tests separately

if I click on submit with empty input or add space without any character it will add, so you can use this or try to solve it as you like

  if(inputText.value.trim()){

it will remove space from the start of a string and check if there a real value

solve the conflict in this lines , the conflict from this branch ( 60-sort-button)

2nd and 3rd test id should change because generateId() keeps counting
relates #3 #5

relates #6

dom.js:107 Uncaught TypeError: Cannot read property 'addEventListener' of null
    at HTMLFormElement.<anonymous> (dom.js:107)

because you have a mistake when you get the element, you writ this line

 var sortFormBtn = document.getElementById('add-todo input[type=button]');

but when you back to index.html there isn`t this id for sort button and getElemetBy
Id can't use as you used, so add an id for the button and use getElemetById in the right way your error will be solved.

make sure that tests coverage is good enough, and at least 95%
delete the if of the export in logic.js

relates #3

• createTodoNode
• addTodoForm if
• save to local storage
• reloading from local storage
• trying everything out and everything will stay on the same page

https://github.com/GSG-G7/AMAI-TODO-List/blob/e4a59a1b3557d1936017266d8de1529be7bde12c/JS/logic.js#L28is
each push make sure there aren't any comment lines

1- creat checkbox input.
2- add mark todo function to checkbox-input.

test for the delete function

relates #16

fix conflict

between done and not done
#28

todoFunctions.addTodo in logic.js
tests before code, separate branches and pair programming

JS

• logic.js
• dom.js

CSS

• style.css

test

• test.js

index.html

and npm init, install tape, and .gitignore ready

relates #3

why your issues without description?
just write small description of what will do in issue

if mark must icon (/) if not mark (|_|)

you make a test for editTodo function but this function isn't defined in the logic.js file, I think you have lost lines in the logic.js file

#28

there no input validation

relates #31

move the sort button out the if statement block

#47

write body code
relates #12

create tests
relates #12

the sort and submit buttons are not responsive

relates #28

put all done todos in new array

don't use tag name in CSS use class name and :)

• make Classes inside dom.js
• then use these classes in dom by element.classlist.add or toggle
• use bem naming convention

always try to get all element in the top of the code

read this issue:
GSG-G7/Get-Organized-Team-#55

do testing and code of todoFunctions.editTodo

todoFunctions.deleteTodo in logic.js
create separate branches for test and function bod

make form on top so it stays on top and dont move when we add more stuff