gsg-g7 / amai Goto Github PK

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L40

the id is a unique thing for tag no tag have the same id, you use id "about" two in nav and for section

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/JS/index.js#L33
remove this line

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L68

it will be more better if add all media query at the bottom of file.

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L46

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L36

read this about BEM classes :
http://getbem.com/naming/

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L407

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/JS/index.js#L1-L9
try to make this function to don't repeat code

function getElements(nodesName, selectors) {
  const elements = {}
  if (nodesName.length === selectors.length) return 'Error';
    selectors.map((selector, index) =>
      elements[nodesName[index]] = document.querySelector(selector);)
return elements;
}

const {a, b, c} = getElements(['a','b','c'], ['.a','.b','.c']);

These classes don't follow BEM
member-img
contact-us--btn (you should be consistent, either use -- or __)
home__btn__call (is call the modifier? if yes, use --)

Remember Block__Element--modifier rule.
Here is an article on BEM if you're interested in further reading.

indentation in the HTML and JS files is 4 spaces
and in the style file 2 spaces

The good indentation is 2 spaces try to do this to all files

the Page Title doesn't a good title !!

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L127-L130

why use
here
and br is a self-close tag and you don't close it and you don't use it as a self-closing tag
read this about self-closing tag :
https://www.quora.com/Which-HTML-tags-are-self-closing

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L17

Remove the branch when you finish from it

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L167

don't use a tag to select in css

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L421

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/JS/index.js#L1

use one selector if you don't need more than one

there are 10 opened branches !!!!!

id attribute, has to be unique and not repeated !!

Line 22 and Line 42

<li><a id="about">About</a></li>

Line 63, Line 74, Line 85, and Line 98

<div id="member" class="member">

Line 65, Line 76, Line 87, and Line 100

<h3 id="name">

put all the media queries at the end

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L134-L135

as fieldset parent to div, the div should close before fieldset

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L429

All of your general stylings should be at the beginning of the file, including css for global, body, HTML, headings, anchor and etc.

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L37

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L113

why use action and method

Good Job and nice work with GitHub flow
I'll write my comment in the next issues

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L376
it will be better if you give nav class name and call it here by class name not tag itself

Readme file should at least contain:

• Why/ how/ what
• team members
• user journey/ story
• technologies used

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L417

  }main li {
   .about__content {
    width:100%
  }

lang attribute has to be defined !!

Here in your case has to has en value

the accessibility just 82% !!!

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L402

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L5-L11

try to Arrangement tags E.x( meta, title then link)
more readable code

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L407

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L17

I noticed that you never used this class home__btn__call in your css. So, remove it if you don't intend to use it.

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/CSS/style.css#L389-L435

#11

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/JS/index.js#L11-L13

 homeBtn.addEventListener('click', () => { 
     showSection(home); 
 }) ;

https://github.com/ca-g7/AMAI/blob/964a341fb1c8deb85b647d120ea3457c42f22e62/index.html#L31
why span and don't have own style, you don't need it in a span