Allow for named color vector input for msn functions about poppr HOT 4 CLOSED

This has been fixed. There was something weird with match.fun(), but setting descend = FALSE did the trick. I also added a new feature that would give you what I'd hope you'd expect.

For future reference, if you find a bug that stemmed from a new feature, please raise a separate issue; it makes things easier to track down.

from poppr.

Why did you reopen this? This issue was fixed in #57.

from poppr.

Documentation states that the function poppr.msn() will accept a vector of colors. I may have found an exception.

A.dist <- diss.dist(Aeut)
A.msn <- poppr.msn(Aeut, A.dist, gadj=15, vertex.label=NA)

From examples works.

RColorBrewer::brewer.pal(n=3, name = 'Set3')
A.msn <- poppr.msn(Aeut, A.dist, gadj=15, vertex.label=NA, palette=RColorBrewer::brewer.pal(n=3, name = 'Set3'))

Throws an error.

Error in PAL(npop) : invalid argument type

Is poppr.msn trying to interpret this as a function instead of a vector of colors?

Thanks!

from poppr.

That's an interesting problem. The function responsible for figuring out if a palette is a vector or function is [palette_parser](

I'll have a look at this later.

Zhian

On Mar 29, 2016, at 09:30 , Brian Knaus [email protected] wrote:

Documentation states that the function poppr.msn() will accept a vector of colors. I may have found an exception.

A.dist <- diss.dist(Aeut)
A.msn <- poppr.msn(Aeut, A.dist, gadj=15, vertex.label=NA)
From examples works.

RColorBrewer::brewer.pal(n=3, name = 'Set3')
A.msn <- poppr.msn(Aeut, A.dist, gadj=15, vertex.label=NA, palette=RColorBrewer::brewer.pal(n=3, name = 'Set3'))
Throws an error.

Error in PAL(npop) : invalid argument type
Is poppr.msn trying to interpret this as a function instead of a vector of colors?

Thanks!

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub #55 (comment)

from poppr.