Git Product home page Git Product logo

Comments (2)

JonahBrooks avatar JonahBrooks commented on September 25, 2024

I've fixed a plethora of small bugs and issues with the diploid version of bitwise.IA. It now produces values fairly close to the existing win.ia code. Unfortunately the output is still not exactly the same, and occasionally spikes upwards of 20% relative error (although it averages much better than that). It seems something is wrong with the accumulation of distance at each locus (M[] and M2[]). Everything else is matching up to win.IA exactly.

Right now I can generate the following output from both functions while running ia_comparison. Each time the values shown are computed they are written to a file. This is the diff between (the first few differences in) those two output files ( > represents bitwise.IA output, < represents snpia):

2,5c2,5
< Sd*Sd/np:1543.372929
< Sd2:3384
< vars:0.371844
<  
---
> Sd*Sd/np:1722.505051
> Sd2:3664
> vars:0.392221
> 
9,21c9,21
<  
< Sd*Sd/np:986.686869
< Sd2:2210
< vars:0.247134
<  
< Sd*Sd/np:2673.746263
< Sd2:4982
< vars:0.466314
<  
< Sd*Sd/np:1355.171717
< Sd2:3110
< vars:0.354511
<  
---
> 
> Sd*Sd/np:1138.560808
> Sd2:2504
> vars:0.275846
> 
> Sd*Sd/np:2872.816364
> Sd2:5211
> vars:0.472360
> 
> Sd*Sd/np:1527.777778
> Sd2:3400
> vars:0.378227
> 
29,37c29,37
<  
< Sd*Sd/np:1813.336566
< Sd2:4004
< vars:0.442558
<  
< Sd*Sd/np:1961.506263
< Sd2:4480
< vars:0.508787
<  
---
> 
> Sd*Sd/np:2004.545455
> Sd2:4284
> vars:0.460496
> 
> Sd*Sd/np:2560.323232
> Sd2:5296
> vars:0.552662
> 
41,45c41,45
<  
< Sd*Sd/np:1397.353535
< Sd2:3250
< vars:0.374272
<  
---
> 
> Sd*Sd/np:1931.406869
> Sd2:4084
> vars:0.434867
> 
49,53c49,53
<  
< Sd*Sd/np:983.118384
< Sd2:2342
< vars:0.274522
<  
---
> 
> Sd*Sd/np:1136.643232
> Sd2:2644
> vars:0.304517
>

from poppr.

JonahBrooks avatar JonahBrooks commented on September 25, 2024

Commit c4059d2 resolves the issues and completes this functionality. bitwise.IA should now correctly support diploids.

from poppr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.