grumpycrouton / grumpypdo Goto Github PK

Expected Behavior

I expect the query to work

Actual Behavior

The query doesn't work :(

Steps to Reproduce the Problem

1. $pdo = new GrumpyPDO($host, $user, $pass, $db, PDO::CASE_LOWER)

Specifications

Saw your project on Codereview and was creeping looking for a pull request for Hacktoberfest but I don't see anything I can do.. I did notice this little issue tho, if a non-null, non-array value is passed to the constructor for the $attributes parameter your code won't catch it and PDO will end up throwing an error.

Problem is

if($attributes == NULL && !is_array($attributes)) {

should be

if($attributes == NULL || !is_array($attributes)) {

which should really just be

if(!is_array($attributes)) {

cheers!

Expected Behavior

Propery query returned

Actual Behavior

Error: Internal Server Error PDO::query(): SQLSTATE[HY000]: General error: constructor arguments must be passed as an array

Steps to Reproduce the Problem

1. Run a query (all()) with no variables; $facilities = $db->all("SELECT uid, name FROM rc_facilities");

Expected Behavior

How do I call the native member functions of PDO Class, such as lastInsertId()?

I will actually do this in my spare time, if and only if you have good test code coverage already.

EDIT: Ooops. Zero tests. Good luck :-/