groodlooker / vega-lite Goto Github PK

The charts are a little too big in looker and are causing scrolling issues.

The issue seems to be that the logic to fix the sizing in the spec property doesn't account for the legend or axis.

I think a couple of minor adjustments resolves this:

1. Use svg instead of canvas. SVG is a little easier to size than a canvas element and is also called out as a potential sizing fix by one of the maintainers here
2. Implement a function to fix the sizing of the svg after the chart has been rendered. Basically, get the looker container div#vis so we can grab the clientHeight/clientWidth then update the svg with the same dimensions after it's rendered.

First of all thanks for all the awesome work!

I really like the VEGA custom visualizations, but currently there is no way to show labels on charts.

It should be rather easy to add. One example with labels - https://vega.github.io/vega-lite/examples/layer_bar_labels.html

Thanks again!

In vega-3-2-.js, around line 509, it has...
"scale":{"zero":config['y2']}

But in other places above that, it has...
"scale":{"zero":config['unpin_y']}

Is there any reason why vega-3-2.js is not in the git?

Can you implement this: https://vega.github.io/vega-lite/docs/stack.html#normalized

This could help us to move lots of looks to VEGA for better overview of our numbers

Unless I missed it, I don't see capabilities to leverage the sorting capabilities inside Looker - this would be a nice feature to have. Documentation lives here: https://vega.github.io/vega-lite/docs/sort.html

Is there a way to pull in a custom defined looker color scheme into the vega visualizations?

Hi,

it seems that all aws links have died or access denied. Is there a way to obtain vega-lite-3-1.js?

Thanks in advance

Hey @groodlooker & @mswilson4040 👋

The bundled js link that you supply in your README file (which we use for our Looker env's vega-lite extension) leads to an error: "The requested project was not found."

https://storage.googleapis.com/custom-visualizations/bundle.js

🚨

Currently weekday fields in Looker are sorted alphabetically.

Can you make it to sort from Mon-Sun or ability to choose how weekdays are sorted?

https://vega.github.io/vega-lite/docs/sort.html

Plotting a measure with a label that contains a newline character (This is a newline in the LookML, presumably \n) causes the Vega viz to break.

There is at least one real world application for this, which is using liquid to format the labels.
For readibility, these are often formatted like this (note the newline after the first if block)

label: "{% if param._parameter_value == 'Yes' %}Gross Margin (GBP)
    {% else %}Gross Margin (GBP)
{% endif %}"

Here is the stack trace:

newline_bug_console_log.txt

Hello @groodlooker ! Thank you so much for creating this library.

We want to modify this library and use it in commercial projects. Can you please tell what type of license the code has?

Thanks!

Hi,

The chart is not giving space between values and label. They comin mixed up in the output.
Any way to fix this?

Attempting to add Reference Line X or Reference Line Y in 4.Settings causes the below Uncaught Error (Chrome Version 71.0.3578.98 (Official Build) (64-bit))

The viz will not update or function correctly until the reference line is deselected

model.ts:616 Uncaught (in promise) Error: Cannot find a selection named "paintbrush"
    at FacetModel.Model.getSelectionComponent (model.ts:616)
    at LayerModel.Model.getSelectionComponent (model.ts:613)
    at UnitModel.Model.getSelectionComponent (model.ts:613)
    at expr (selection.ts:244)
    at logicalExpr (util.ts:297)
    at selectionPredicate (selection.ts:266)
    at mixins.ts:248
    at Array.map (<anonymous>)
    at wrapCondition (mixins.ts:246)
    at nonPosition (mixins.ts:219)