Git Product home page Git Product logo

enum's People

Contributors

jkuchar avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

enum's Issues

checkCallStaticAnnotations fails if method provideInstances is in abstract class

ConsistencyChecker will throw Grifart\Enum\UsageException: You have forgotten to add @method annotations for enum 'Survilla\Enum\Enum'. Documentation block should contain if Survilla\Enum\Enum is an abstract class declaring provideInstances method.

/**
 *@method static ExampleEnum ONE()
 *@method static ExampleEnum TWO()
 *@method static ExampleEnum THREE()
 */
class ExampleEnum extends MyEnumsAbstract {

  private const ONE = 'one';
  private const TWO = 'two';
  private const THREE = 'three';
}

abstract class MyEnumsAbstract extends \Grifart\Enum\Enum {

  use Grifart\Enum\AutoInstances;

 /** Some common behavior... **/

}

Interface instead of abstract class

Hi, personally I don't like abstract classes and static calls... What do You think about this implementation?

interface DayOfWeek
{
    public function nextDay(): self;
}

class Monday implements DayOfWeek
{
    public function nextDay(): DayOfWeek
    {
        return new Tuesday();
    }
}

class Tuesday implements DayOfWeek
{
    public function nextDay(): DayOfWeek
    {
        return new Tuesday();
    }
}

Update readme

  • composer require
  • versioning notes (as brick has)
  • state machine example (order state)
  • bevaiour example - promotional tickets FIXED and RELATIVE and using calculator to compute due date
  • fix typos

Simpler implementation suggestion

Hi, when I read the Enum, I find a lots of abstract concepts that are difficult to understand... is anything wrong with this implementation?

abstract class DayOfWeek
{

    protected const MONDAY = 'monday';
    protected const TUESDAY = 'tuesday';

    public abstract function nextDay(): self;

    public static function MONDAY(): self
    {
        return new class extends DayOfWeek
        {
            public function nextDay(): DayOfWeek
            {
                return DayOfWeek::TUESDAY();
            }
        };
    }

    public static function TUESDAY(): self
    {
        return new class extends DayOfWeek
        {
            public function nextDay(): DayOfWeek
            {
                return DayOfWeek::WEDNESDAY();
            }
        };
    }
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.