The ext.data.proxy.websql from grgur

If you want to see the pictures of my dog, click here. If you want to see what's on my mind, click here.

👨👩 Social 🔝

ext.data.proxy.websql's People

Contributors

Stargazers

Watchers

ext.data.proxy.websql's Issues

Can't remove records

Hi, I have 7 records in my store. I call

        storeExams.removeAll();
        storeExams.sync();

I get the following error:

Uncaught TypeError: Cannot read property 'length' of undefined
Line 369

I get the same result if I loop over every record, call remove and then try to sync.

I just toyed a bit with your library in Sencha Touch 2 and I encountered a few bugs which I was able to fix :). It didnt work with id fields with a name other than 'id'. And it threw an error on destroy sometimes.

Here is the patch file:

Index: WebSqlProxy.js
===================================================================
--- WebSqlProxy.js  (revision 8794)
+++ WebSqlProxy.js  (working copy)
@@ -169,7 +169,7 @@
             var name = f.getName(),
                 type = f.getType().type;

-            if (name.toLowerCase() !== 'id') {
+            if (name.toLowerCase() !== me.getPkField().toLowerCase()) {
                 type = type.replace(/int/i, 'INTEGER')
                     .replace(/string/i, 'TEXT')
                     .replace(/auto/i, 'TEXT')
@@ -365,12 +365,12 @@

     //inherit
     destroy      : function (operation, callback, scope) {
-        var records = operation.records,
+        var records = operation.getRecords(),
             length = records.length,
             i;

         for (i = 0; i < length; i++) {
-            Ext.Array.remove(newIds, records[i].getId());
+//            Ext.Array.remove(newIds, records[i].getId());
             this.removeRecord(records[i], false);
         }

@@ -548,7 +548,7 @@
         var me = this;

         me.getDb().transaction(function (tx) {
-            tx.executeSql('DELETE FROM ' + me.getDbTable + ' WHERE ' + me.getPkField() + ' = ?',
+            tx.executeSql('DELETE FROM ' + me.getDbTable() + ' WHERE ' + me.getPkField() + ' = ?',
                 [id],
                 Ext.emptyFn, //on success
                 Ext.bind(me.onError, me));        // on error