gregorym / atom-inline-blame Goto Github PK

Currently it supports relativeTime and authorTime in the Format setting. relativeTime looks like it's the number of seconds since the commit. It would be great if that could be formatted as a datetime value (yyyy-mm-dd hh:mm:ss), or if the current way it's doing it needs to be maintained, to provide an additional dateTime format token that would apply the formatting (perhaps with moment.js).

This would really help if you have 2 lines where they both say "about a year ago" with relativeTime, and the number of seconds is a bit difficult to compare visually.

Very useful package, by the way. Thanks!

How do I switch to display or not for keybindings. Is there any shortcut can allow me to control it?

Argument to path.dirname must be a string

Object.dirname (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:9:10)
<unknown> (/Users/aporter/.atom/packages/atom-inline-blame/lib/GitBlameHelper.js:20:64)
Promise (null:null:null)
Object.run (/Users/aporter/.atom/packages/atom-inline-blame/lib/GitBlameHelper.js:18:10)
InlineBlameView.updateLine (/Users/aporter/.atom/packages/atom-inline-blame/lib/InlineBlameView.js:83:35)
<unknown> (/Users/aporter/.atom/packages/atom-inline-blame/lib/InlineBlameView.js:66:9)

Hi,
The inline blame (::after) flicker when it appear.
I think this is caused because a fadeIn keyframes is already defined in another package.
Maybe you could prefix your @Keyframes with your package name the prevent this ?
I also recommend prepending the message with "//" like VS Code. Show that this is a comment and prevent people from getting confused.

I'm in a reasonably large git repo. When I have this extension enabled, Atom is noticeably slow when I click the mouse to move the cursor. The cursor doesn't draw in the new places until about 300-500ms have passed.

Is this extension making a synchronous call to git in an event handler for cursor position change?

[Enter steps to reproduce:]

1. ...
2. ...

Atom: 1.37.0 x64
Electron: 2.0.18
OS: Mac OS X 10.14.5
Thrown From: atom-inline-blame package 0.0.6

Stack Trace

Uncaught TypeError: Cannot read property 'trim' of undefined

At /Users/jhabibi/.atom/packages/atom-inline-blame/lib/InlineBlameView.js:56

TypeError: Cannot read property 'trim' of undefined
    at InlineBlameView.updateLine (/packages/atom-inline-blame/lib/InlineBlameView.js:56:58)
    at /packages/atom-inline-blame/lib/InlineBlameView.js:42:9

Commands

Non-Core Packages

aligner 1.2.4 
aligner-css 1.2.1 
aligner-javascript 1.3.0 
aligner-ruby 1.7.0 
aligner-scss 1.3.1 
atom-beautify 0.33.4 
atom-inline-blame 0.0.6 
atom-material-syntax 1.0.8 
atom-material-syntax-dark 1.0.0 
atom-material-ui 2.1.3 
busy-signal 2.0.1 
city-lights-syntax 1.1.8 
city-lights-ui 1.5.3 
elm-format 3.2.0 
file-icons 2.1.32 
fonts 3.4.0 
intentions 1.1.5 
language-dots 0.0.4 
language-elm 1.5.0 
linter 2.3.0 
linter-ui-default 1.7.1 
pigments 0.40.2 
prettier-atom 0.56.5 
pure-ui 1.0.4 
rails-snippets 2.21.0 
railscast-theme 0.4.0 
react 0.18.0 
rspec 0.4.0 
script 3.18.1 
seti-syntax 1.2.0 
seti-ui 1.11.0 
teletype 0.13.4 
unity-ui 2.1.11 

When the project path contains a space, console contains fatal: bad revision error.

Discovered in #7 (comment).

In atom 1.33.0 (Fedora 29), both hotkeys and content menu toggles have no effect.

Similarly to Git Lens it would be great to be able to hover over the line and have a panel open with the entire commit message and a diff for that given line.

The startup time for atom-inline-blame is very high (it fluctuates between 200ms - 900ms) when it most probably shouldn't be. Maybe there should be some kind of delayed activation?