gregjopa / ember-power-select-form Goto Github PK

@cibernox - I'd like to get your feedback on this new ember-power-select addon I created. The README contains some details about the purpose of this addon and the architecture details. Checkout the example ember app in the tests/dummy directory to see this addon in action.

I know this addon is an edge case for ember-power-select. But the composition design pattern used with ember-power-select made it pretty easy to create.

The following two things felt hacky to me when overriding the selectOptions component:

1. Triggering the onchange event - I did this by triggering the select event and passing through the transformed parameters. I wasn't sure how to pass the dropdown param so I just left it blank. https://github.com/gregjopa/ember-power-select-complex/blob/master/tests/dummy/app/components/select-options.js#L62
2. Closing the dropdown - I did this using the opened api option. I used this.get('targetObject') to get access to the main component from inside the selectOptions component. Is there a better way to refer to the parent component?

Any feedback you have would be greatly appreciated.