gregdardis / stock-market-search Goto Github PK

• user-facing constants
• calculation constants
• formatting specifiers

see the TODO in src/constants/index.js
edit: I (Greg) removed the TODO, just see this issue.

• stub out parseIntExact in src/utils/stockDataUtils/createStockDataEntry.test.js
• stub out parseIntExact in src/utils/stockDataUtils/calculations.test.js
• finish tests for src/utils/apiUtils/chartData.js

Steps to (not consistently) reproduce

1. Run app
2. Search for GOOG
3. Sometimes, on weekends, there will be open space in the graph where it should just skip from Friday to Monday.

Not really sure when this happens, just seems to be random

Make the search bar autocomplete based on a database of stock symbols (and possibly company names too)

Once I figure out how to debug with breakpoints instead of using "debugger"

We want them to be nice and easy to read. Currently they look bad

If the user enters a valid symbol, do a progress wheel?

Otherwise tell the user the symbol doesn't exist and to try again or something

Take out the part that says some features are incomplete. It is always being worked on but now the project is more presentable.

Haven't put much thought into whether the grid should be styled differently.

Figure this out, and either apply the needed styling or do nothing, then close this issue.

npm script to generate shareable URL to share changes easily

Steps to reproduce:

1. Search a valid stock
2. Mouse over the chart in any time period
3. Look at the price
4. IT'S MESSED UP!

Tooltip is poorly formatted. Hovering over a data point on the line chart shows a date and then the security price for that date.

This is written as price : securityPrice for some reason, with a space between the word "price" and the ":".

Tried for a little bit to fix this, seems built in and every question I have seen about recharts still has this space in that spot.

Before the user searches a symbol, there is placeholder text below the search bar.

Figure out what to do with this space in the meantime.

Trying to put a function in utils/apiUtils/chartData.js and then import & call it in client code caused many errors in the npm run dev terminal and prevented the app from running.

Example error:

ERROR in ./node_modules/request/lib/har.js
Module not found: Error: Can't resolve 'fs' in '/Users/Hailey/GitHub/stock-market-info/node_modules/request/lib'
 @ ./node_modules/request/lib/har.js 3:9-22
 @ ./node_modules/request/request.js
 @ ./node_modules/request/index.js
 @ ./node_modules/request-promise/lib/rp.js
 @ ./src/utils/apiUtils/chartData.js
 @ ./src/client/reducers/chartTimePeriodIndex.js
 @ ./src/client/reducers/index.js
 @ ./src/client/render.js
 @ multi (webpack)-dev-server/client?http://localhost:8080 webpack/hot/dev-server ./src/client/render.js

See title - it looks gross

Consider using this in mapDispatchToProps

Make a maximum number of characters that will go in the search component input. Stock symbols are not that long

Take into consideration that the stock's data might not be up to date anymore...

Currently server just gets a bunch of errors but program continues to work if you search for a symbol that doesn't exist.

Make this work more as expected, handle the errors, show the user some feedback, etc

https://www.npmjs.com/package/eslint-plugin-node

Steps to reproduce:

1. Run app
2. Search for a valid stock symbol
3. When the search is completed and the graph is shown, the search bar is moved to the left to align with the graph and company information. Unintended!

Make webpack.config.dev.js and webpack.config.prod.js

Steps to reproduce

1. Go to localhost:8080
2. Click glossary in NavBar
3. Math formulas are not loaded!
4. Refreshing page loads the Math formulas

Could be a problem with the CDN, try loading MathJax in a different way.

eslint-watch has some positives as opposed to eslint-loader which is what we are using.

1. Not tied to webpack
2. Can use it to lint tests and scripts instead of just things being bundled by webpack

src/utils/stockDataUtils/createStockDataEntry.js

Get web hosting, put the URL in the README

The line that allows it to work in development is in webpack.config.js and is
devServer: { historyApiFallback: true }.
I don't think this works in production. See https://stackoverflow.com/questions/27928372/react-router-urls-dont-work-when-refreshing-or-writting-manually

This will get rid of the red border around the search input when the user presses search

https://github.com/john-doherty/selenium-cucumber-js#readme

Features:

• Glossary
  • Navigate to glossary from home page
• Search stock
  • Search invalid stock
  • Search valid stock
  • Search using the ENTER key
  • Clear search by pressing ESC
• Price chart
  • Change time period

Probably related to #51 .

Errors: The above error occurred in the <CartesianGrid> component: and TypeError: "Invalid date"

Currently, app.get('/api/stocks/:symbol', (req, res) is a huge mess. Need to factor out some functions of something.

Also, maybe we can rework it so we don't wait on each response before we send the next request.

Steps to reproduce:

1. Start up app
2. Search a lowercase stock symbol (i.e. goog)
3. Look at state using redux dev tools
4. Observe there is both a stock in stockData for 'goog' which has empty strings for each part of it's state, and for 'GOOG' which has the actual information about google.

Consider using chai-enzyme for assertions here: https://github.com/producthunt/chai-enzyme
Also see: https://github.com/airbnb/enzyme/blob/master/docs/guides/mocha.md

Components

• App
• AppWrapper
• Chart
• Column
• CompanyGeneralInfo
• CompanyNameAndSymbol
• DataItem
• Definition
• Exchange
• Glossary
• Home
• NavBar
• PriceAndTodaysPriceChange
• Row
• Search
• SearchLoader
• SelectableTimePeriodChart
• StockDataRegion
• TimePeriodButtons

Steps to (unreliably) reproduce

1. Run the app
2. Search for a valid stock symbol
3. Click around through time period buttons with console open
4. Eventually at some point an error will come up when you click the 5 day button.

This error doesn't crash the app, and the 5 day data is still displayed on the chart properly (I think).

sometimes the numbers printed don't seem right

I don't know what this means, it was on my TODO list because Hailey told me to write it at some point.

Lets do it together so we can learn?

Learn about and implement responsive web design, so the app works well on phones and in smaller browser windows, etc

Currently, you have to re run the server every time you make a change to it, because when we started using babel-node, nodemon stopped working.

Figure this out.