gree / flare Goto Github PK

Hi,There are some same code in Flarei.cc.

The line number is 272 and 282。We can see this:The two "if block" are same.

So,is anythings wrong with it?

thanks.

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

• pthread_rwlock_init ⇒ thread_pool constructor
• pthread_cond_init ⇒ thread_queue::sync_ref

I find that include guards like "APP_H" and "CLIENT_H" are too short for the safe reuse of your header files.
How do you think about to make them not only standard-compliant but also really unique by appending a kind of UUID?

Hi,

Currently I can see that it doesn't support building with CLANG. Do you have any plan to add CLANG support in near future?

BR,
Muhammad

Hi friends,I try to store a data item for a month,so that's the command:
telnet localhost 12121
Trying 127.0.0.1...
Connected to localhost.yahoo.com (127.0.0.1).
Escape character is '^]'.
set key1 0 2678400 3
123
STORED
But when I try to fetch the data:
get key1
END
I got nothing.
What's wrong?Is there any restriction about the expiration?

When using binary protocol, cas token is always zero.

We need't the super-user's privilege when listening on port large then 1024

I would like to point out that identifiers like "__FLARED_H__" and "__CONNECTION_TCP_H__" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

An extra null pointer check is not needed in functions like the following.

• connection_tcp
• key_resolver_modular
• mysql_replication::parse

I edited /etc/syslog.conf as the document,but I can't found the log file.

Would you like to add the configuration script "AX_PTHREAD" to your build specification?

Build failed on Fedora 11 gcc (GCC) 4.4.0 20090506 (Red Hat 4.4.0-4)
because of missing include in logger.h, I added #include <stdio.h> and it worked.

the compiler barfs on vsnprintf not being declared.
I fixed that locally and hope you fix that on the repo.

Hi,There is something wrong with "Installation of Flare",When I download "flare-1.0.5.tgz",typing "tar zxvf flare-1.0.5.tgz",then has error:"gzip: stdin: not in gzip format\n tar: Child returned status 1\n tar: Error is not recoverable: exiting now.My OS is Centos 6.3 finall. tar 's version is 1.23. Thanks.

i just create memory disk:

mount -t ramfs none /mnt/flare/ -o maxSize=52428800

the master node which put file to disk has 1 balance, then the slave node which put file to /mnt/flare/ has 999 balance.

Any advance is appreciate

Tokyo Cabinet, Flare の Debian パッケージへのリンクが切れています。

• http://labs.gree.jp/data/source/tokyocabinet-dev_1.3.20-1_i386.deb
• http://labs.gree.jp/data/source/flare_1.0.0-1_i386.deb

対象ページ: https://github.com/gree/flare/wiki/Installation-JP

Checkout http://github.com/xurenlu/flare-manager please.

The function "vsnprintf" does not belong to the list of async-signal-safe functions.
I guess that a different program design will be needed for your function "sa_term_handler".