grayda / bellboy Goto Github PK

To test this, create three bells: One that runs every day at 9am, one that runs every day at 12pm and one that runs every day at 3pm. Let the 9am bell ring, then disable the 12pm bell. At 1pm, enable the 12pm bell again. Notice how 12pm was marked as the last bell to ring.

Expected result: 9am bell should be the last one to ring, as it actually triggered
Actual result: 12pm bell is marked as the last bell to ring.
Why this occurs: GetPreviousJob is the reverse of GetNextJob, so instead of Bellboy keeping track of what item it last triggered, it merely gets all jobs, calculate the previous 1 time and assumes that was the last job.
Severity: Low. Doesn't really affect operation, but may be confusing to those who assume the previous chronologically ordered job is the last one to fire, even when it wasn't.

This is a scratchpad of sorts for me to jot down ideas.

• Publish plugins to npm
  • Would allow npm install --save bellboy-rest or similar
• Have an installer gulp task that scans the plugin folder and adds the items to plugins.json
  • Easy to implement: Load plugins.json as an object, load package.json as an object. packagePath = the path, options are copied from package.json, restart nodemon and you're all sorted, as long as the plugins don't crash
• Bring back the crash JS. If plugins fail to load, somehow alert the user or roll back to default file
• Expansion would allow things like timekeeping (e.g. tap an RFID card which a plugin reads and emits an event