Comments (23)
marceloverdijk
commented on July 29, 2024
15
Spring Boot 2.0.0 GA was released today. Probably good to upgrade this project as well and maybe make a new release?
from graphql-spring-boot.
apottere
commented on July 29, 2024
6
Version 4.0.0.M1 is syncing to central now!
from graphql-spring-boot.
heruan
commented on July 29, 2024
4
I've rebased the PR and updated to Spring Framework 5.0.2.RELEASE and Spring Boot 2.0.0.M7 which is the latest milestone.
I understand @apottere concerns about releasing with a milestone dependency, and I agree to wait.
But I see no reason why not to release a milestone version of this plugin right now, e.g. 4.0.0.M1, with compatibility with Spring Boot 2.
from graphql-spring-boot.
apottere
commented on July 29, 2024
3
I can definitely release a snapshot/milestone version with these changes - I hadn't thought of that.
from graphql-spring-boot.
geowarin
commented on July 29, 2024
3
Hello!
For those interested, I wrote an application in kotlin with graphq-java which uses webflux directly (no servlet).
I hope it will be useful if you guys decide to support webflux in the future.
from graphql-spring-boot.
apottere
commented on July 29, 2024
3
Sorry it took me so long to get to this, it's released in 4.0.0
from graphql-spring-boot.
sdeleuze
commented on July 29, 2024
2
Shouldn't Boot 2.0 support also include support for Spring WebFlux ?
from graphql-spring-boot.
kganger
commented on July 29, 2024
2
It would be really helpful to get at least a snapshot release with this support
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
2
Is the plan to maintain/release different versions for Boot 1.5 and 2.0?
In that case it might be interesting to deliver a release based on latest Boot 2.0 M7. It’s quite stable and already used in production 😉
I’m currently experimenting with Graphql in an existing Boot 2.0 M7 app and unfortunately I have to create all beans manually as the Graphql Boot starter does not support 2.0.
What is holding you back to provide a release with 2.0 support (as multiple people are asking)?
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
2
For the rest I can confirm the GraphQL Boot starter 4.0.0.M1 works with Boot 2.0 M7 🍾
from graphql-spring-boot.
sazzer
commented on July 29, 2024
1
It seems a nice idea if the entire graphql server could be non blocking,
but I'm not sure how feasible that is since the graph structure
necessitates some parts to be computed only after other parts have finished.
…On Wed, 13 Dec 2017, 15:39 Andrew Potter, ***@***.***> wrote:
What parts of webflux would the servlet need to support?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAECGJUcgtye0qgDskrGbn-1xxvM6AL0ks5s_--jgaJpZM4PtqGh>
.
from graphql-spring-boot.
apottere
commented on July 29, 2024
There's a PR open for updating to support Spring Boot 2.0.0, (#36), but I'm waiting for it to have a non-milestone release first.
from graphql-spring-boot.
apottere
commented on July 29, 2024
What parts of webflux would the servlet need to support?
from graphql-spring-boot.
sdeleuze
commented on July 29, 2024
@apottere I guess the integration would not be as a Servlet, see https://docs.spring.io/spring/docs/current/spring-framework-reference/web-reactive.html#spring-webflux. For example functional endpoints allow programmatic registration of routes.
@sazzer I am not familiar with GraphQL, but even if a full non-blocking solution for the graph could be appealing, maybe you could just support a similar integration than with Servlet as a first step, just leveraging WebFlux infrastructure instead of Servlet one. Does GraphQL processing requires using blocking IO ?
from graphql-spring-boot.
sazzer
commented on July 29, 2024
I've no idea if it *requires* blocking IO per-se. However, what you often
have is almost reentrant processing - child nodes can only be evaluated
after the parent nodes are completely loaded, and I'm not sure if that
would be a problem at all. All the webflux examples I've seen have been:
read from database, convert to output, stream to client, and this would end
up being that structure repeated several times for one request.
…On Wed, 13 Dec 2017, 16:16 Sébastien Deleuze, ***@***.***> wrote:
@apottere <https://github.com/apottere> I guess the integration would not
be as a Servlet, see
https://docs.spring.io/spring/docs/current/spring-framework-reference/web-reactive.html#spring-webflux.
For example functional endpoints allow programmatic registration of routes.
@sazzer <https://github.com/sazzer> I am not familiar with GraphQL, but
even if a full non-blocking solution for the graph could be appealing,
maybe you could just support a similar integration than with Servlet as a
first step, just leveraging WebFlux infrastructure instead of Servlet one.
Does GraphQL processing requires using blocking IO ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAECGKJj9QNisP2hS4XJ5zQS5SoaBqv3ks5s__g_gaJpZM4PtqGh>
.
from graphql-spring-boot.
SamD
commented on July 29, 2024
I just started my first spring boot project and seeing this happen with 1.5.9 RELEASE as well, any suggestions?
On startup there is no endpoint mapped to graphql only graphiql
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
Thx @apottere I will test it asap.
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
@apottere was there a specific reason to usegraphql-java 6.0 and graphql-java-servlet 4.6.0 instead of latest 7.0 and 4.7.0? Maybe just forgot to update the dep versions?
And also graphql-java-tools 4.2.0 instead of latest 4.3.0?
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
Maybe I should raise this in a separate issue but wouldn't it be better to change the com.graphql-java:graphql-java-tools dependency from compile only to compile?
from graphql-spring-boot.
apottere
commented on July 29, 2024
Yeah, I just forgot to update versions. I'm not sure about depending on graphql-java-tools as a compile dependency, since the starter can be used without it. Right now the specific auto-configuration triggers when it sees those classes on the classpath.
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
Yes, you are right regarding graphql-java-tools. I thought it was a mandatory dependency, but indeed it is optional.
from graphql-spring-boot.
ieugen
commented on July 29, 2024
Anything we can do to help out with the release?
from graphql-spring-boot.
marceloverdijk
commented on July 29, 2024
I guess we need @apottere ..
from graphql-spring-boot.
Related Issues (20)
- Customize SimpleDataFetcherExceptionHandler to avoid logException for certain errors HOT 1
- Spring Boot Graphql Remove duplicates from the Response
- SpringDoc bean name conflict error HOT 1
- Latest 15.0.0 version is not compatible with Spring boot 3.0.2 and spring security 6.0.1 HOT 3
- Possibility to add authorization headers to the GraphQLTestSubscription HOT 14
- How to set the bearer token dynamically in graphql-spring-boot playground
- different data response for nullable and non-nullable responses
- @connection not working after Spring Boot and graphql upgrade HOT 1
- CVE-2023-28867 affects all recent versions (including v15)
- `ErrorHandlerSupplier` not always initialized when we first need it
- Query returning the result of previously timed out query
- Support check origin for websocket to secure against cross-site attacks
- Support CSRF on websockets to secure against cross-site attacks
- When upgrading to Spring Boot 3.1.0 we get in the response the tracing information under extensions HOT 2
- MetricsInstrumentation does not implement updated API of TracingInstrumentation provided by graphql-java
- Maven seems to confuse graphql-java version HOT 4
- Request scoped beans aren't accessible in mutation and query resolvers
- Virtual threads support
- Cannot disable tracing response with graphql-spring-boot-starter version 15 HOT 4
- No qualifying bean of type 'com.graphql.spring.boot.test.GraphQLTestTemplate' available : graphql-spring-boot-starter-test:jar:15.0.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql-spring-boot.