Configure GraphQLServlet object mapper about graphql-spring-boot HOT 7 CLOSED

Are you using 3.9.0? I released this change yesterday which should support that: fff13ab

from graphql-spring-boot.

Yes, I am. I've just debugged the bootstrapping of the application and I do see that my configuration is being applied to the object mapper. So, answering my own question, configuration works just fine. I'll close the issue now and if relevant I'll post here (for reference) how I solved my problem.

from graphql-spring-boot.

A bit more debugging shows that the object mapper used to deserialise inputs from mutations is not the same as the one I configured via a bean in the Application class.

When I debug the bootstrapping of the application I see that the module JavaTimeModule is added to a object mapper that already contains the Jdk8Module (as expected).

Before my configuration is applied:

After my configuration is applied:

However, when handling the input of a mutation the object mapper is different (with a different memory address) and no longer has the JavaTimeModule.

from graphql-spring-boot.

It seems that the object mapper that deserialises the values passed into the mutation is not the one in the servlet but instead it's the one in com.coxautodev.graphql.tools.MethodFieldResolver. java-graphql-tools also has it's own ObjectMapperConfigurer abstraction.

from graphql-spring-boot.

I've fixed my problem (deserialising LocalDateTime objects passed in as inputs to mutations) by also registering a bean to configure the object mapper used by java-graphql-tools (which I use to parse the schema definition).

So the final configuration looks like this:

@SpringBootApplication
public class Application {

(...)

    @Bean
    ObjectMapperConfigurer objectMapperConfigurer() {
        return (ObjectMapper mapper) -> mapper.registerModule(new JavaTimeModule());
    }

    @Bean
    SchemaParserOptions schemaParserOptions() {
        return SchemaParserOptions.newOptions()
                                  .objectMapperConfigurer((ObjectMapper mapper, ObjectMapperConfigurerContext context) -> mapper.registerModule(new JavaTimeModule()))
                                  .build();
    }
(...)

}

from graphql-spring-boot.

Ah, yeah. The servlet object mapper handles parsing variables and output, but the graphql-java-tools objectmapper handles marshalling the field input values to java types. It's a little wonky, but since the two libraries can be used independently I'm not sure how to make it better.

from graphql-spring-boot.

It's indeed a difficult one to solve elegantly. If the interfaces for the ObjectMapperConfigurer in both projects would align, then it would be possible to create one configuration bean that would get injected in both sides. It wouldn't be super elegant, but a least would remove the need to configure things twice.

Thanks again for being so active in giving support 👍

from graphql-spring-boot.