Unite forces with another project about graphql-spring-boot HOT 10 CLOSED

merapar/graphql-spring-boot-starter#23

from graphql-spring-boot.

closing: these are two different projects at the moment.

from graphql-spring-boot.

For people visiting this issue later: I would love to combine the two projects and have a single GraphQL-Java spring-boot starter, but afaict the other project is a pretty self-contained spring-boot-starter/servlet/graphql-java-helper and it can't really support other projects. @merapar if you have any ideas about how to integrate the two projects I'd be interested.

from graphql-spring-boot.

I think that would be the best
Together you could become a official spring boot application.

And in my opinion, it was easier to make a new project as a newbie with the project from @merapar, than from this one.
The examples were way easier to understand and implement than here. :)

from graphql-spring-boot.

It's hard to merge the two projects. I assume a replacement of the existing "GraphQL java spring boot" will not be appreciated :-) Than the only way forward is to brainstorm about a third project and pick the best out of the two.

@apottere Don't really get your comment about "it can't really support other projects".

from graphql-spring-boot.

@janfockaert By "can't really support other projects", I meant that right now you can't supply your own graphql schema and have the spring-boot starter expose it for you. The only way to get a graphql endpoint is by using GraphQlFields, so there isn't a good way to add support for other schema builder libraries right now (or even just manually creating a GraphQLSchema).

from graphql-spring-boot.

In comparison, this project doesn't prescribe a certain way of creating the schema, which makes it more versatile but less intuitive. You can use a supported schema library, but you can also just toss a GraphQLSchema you create at it and it'll work just fine.

from graphql-spring-boot.

@janfockaert I realized it wouldn't be too hard to integrate your schema generation classes into this starter, so I made a quick PoC:

autoconfiguration:
https://github.com/graphql-java/graphql-spring-boot/blob/integrage-merapar-autoconfig/graphql-spring-boot-autoconfigure/src/main/java/com/oembedler/moon/graphql/boot/MeraparStarterAutoConfiguration.java

test:
https://github.com/graphql-java/graphql-spring-boot/blob/integrage-merapar-autoconfig/graphql-spring-boot-autoconfigure/src/test/java/com/oembedler/moon/graphql/boot/test/meraparStarter/MeraparStarterAutoConfigurationTest.java

test fields (from readme):
https://github.com/graphql-java/graphql-spring-boot/blob/integrage-merapar-autoconfig/graphql-spring-boot-autoconfigure/src/test/java/com/oembedler/moon/graphql/boot/test/meraparStarter/HelloWorldFields.java

I'm not sure if this is something you'd consider, but it seems to do everything the same way (including properties).

from graphql-spring-boot.

Than the project will have a dependency on "Merapar" starter project, which will confuse people. The starter project should be a simple and transparent.

In next release, the schema file configuration will be supported #22 and latest v4.0.0 release of graphql-java.

from graphql-spring-boot.

Yeah, that was just for the proof-of-concept. The classes like GraphQlFields that actually help build the schema could be separated into a different library from the spring-boot starter classes, and it would make that inclusion less confusing.

from graphql-spring-boot.