Git Product home page Git Product logo

mary-shelley_the-last-man's People

Contributors

gragt avatar

Watchers

 avatar

mary-shelley_the-last-man's Issues

Review

Spelling changes

  • chapter-2-2: Muhammad -> Mehmed in "Muhammad had made the breach..." This originally said "Mahomet." It seems to me that this is referring to Mehmed II's conquest of Constantinople. Spelling his name as "Muhammad" isn't wrong, exactly (it is the Arabic form of his name) but it seems confusing because 1) that's not how his name is usually spelled and 2) "Muhammad" without any regnal numbers or epithets makes me think of the Islamic prophet, which is incorrect in this context.
  • Ispahan -> Isfahan
  • Cashmere -> Kashmir
  • chapter-3-4: "sand-bank" was modernized to "sandbank" in verse. I would revert this because "sand-bank" has a different stress pattern than "sandbank."
  • 7e76e15: I'm not sure I agree with the decision to normalize "Ex-Queen" as "ex-queen." Since "Ex-Queen" seems to be referring to a particular person, I think the original capitalization is fine.
  • baea7b3: Is "Elect" here referring to a particular group of people? I can see the "Ex-Queen" one going either way but I think this one should be reverted because it seems to be the name of a movement.

Other stuff

  • chapter-3-3: You used the timestamp 2097-30-12 where it should have been 2097-12-30.
  • 7806e2d: In this editorial commit, you combined spelling changes with semantication (the span you added around "Laplace"). Unfortunately we've established that this is a no-no in terms of commit hygiene and you should rebase the span addition out of this commit and add it in separately.
  • d9e16f9: In this commit, you added in quotation marks around thoughts. I suppose this is fine as is, but if we are changing the formatting, we might as well follow 8.2.7 and use <q> for the thoughts.
  • The part-* files/sections should be renamed volume-* and use the volume epub semantic.
  • In the CSS, I think the #chapter-3-10 blockquote:last-of-type p rule can be consolidated with the #chapter-3-10 blockquote:last-of-type rule for simplicity's sake.
  • "Over the years, she had lost her husband, Percy Bysshe Shelley, in a boating accident; her close friend, Lord Byron; and her children." -- I think the wording of this sentence in the long description is confusing. "In a boating accident" coming in the middle of what is otherwise a list of people makes the sentence hard to follow.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.