gpfister / gp-swift-font-awesome Goto Github PK

Describe the bug

Sharp is not supported as a regular (pro or free) font. There are two issues:

• Using style = .sharp returns the brands fonts (bug)
• Sharp now support Solid, Regular and Light

To Reproduce

Not required

Expected behavior

It should be possible to enforce a collection in combination with a style (which can be defaulted to regular when not provided). The GPFAText init method should include a collection parameter to select between brands, sharp, pro / free (pro should be used if available, free otherwise).

Screenshots

Not required

Desktop (please complete the following information):

Not required

Smartphone (please complete the following information):

Not required

Additional context

Font Awesome 6.4.0 is the latest release at the time of creating this issue.

Is your feature request related to a problem? Please describe.

The icon.json file, required to get the link between the name and icon, may be duplicated with other resources on the bundle.

Describe the solution you'd like

It would be better to name the file font-awesome.json

Describe alternatives you've considered

Renaming the file and using a script at build time to perform the renaming

Additional context

N/A