Git Product home page Git Product logo

govtechsg / sgds Goto Github PK

View Code? Open in Web Editor NEW
12.0 2.0 4.0 96.41 MB

SGDS is a frontend framework that aims to provide a beautiful common visual language and user experience for visitors of Singapore Government websites.

Home Page: https://www.designsystem.tech.gov.sg

License: Other

HTML 77.11% Ruby 0.09% JavaScript 1.36% Shell 0.05% SCSS 21.39%
singapore-government jekyll webpack javascript design-system

sgds's Introduction

sgds's People

Contributors

clukhei avatar darenng avatar dependabot[bot] avatar gt-angwl avatar haphizi avatar jmestxr avatar johnsonkoh1110 avatar kaschew avatar meanminmenace avatar petrinetang avatar rav3 avatar reedless avatar seng-siong avatar sophiaaachow avatar sylphias avatar tonghauhive avatar weijunyu avatar yang-lijia avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

sgds's Issues

sgds-bottom-navigation background color and text on-hover color lack contrast

In SGDS css, the declaration for the color for the bottom navigation is blue-ish (#4675d3)

.sgds-bottom-navigation a {
       color: white;
       background-color: #4675d3;
       display: block;
       width: 50%;
       padding: 1rem 5rem;
}

Text highlights in this same navigator is also blue-ish (#2c5bba)

.sgds-bottom-navigation a:hover {
     background-color: #2c5bba;
}

Suggestion to change color of a:hover to something with better contrast

Add back source code on NPM packages

Expected Behavior

On npm packages you should include source code files too, instead of only compiled css / js, so we can use separate sass file , not the whole. Why ? because every project is unique, you can't just change it all. it will break current components while we just want to use the sgds masthead, header style, or icons only.

Current Behavior

Current behavior after npm install on node_modules folder I just found compiled css / js files only. Cannot use it as separate saas file.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. npm install sgds-govtech
  2. Look on node_modules/sgds-govtech folder

Add :focus styles for `.sgds-button`

On mobile devices, the :hover styles do not apply for buttons when users "hover" over a button. The styling for :hover needs to be applied for :active states as well.

WCAG compliance checks

Conduct and display results of WCAG compliance checks on all components within static page.

Grid documentation

How grid responds to different browser sizing
What classes are available, eg:

  • is-three-quarters-mobile
  • is-two-thirds-tablet
  • is-half-desktop
  • is-one-third-widescreen
  • is-one-quarter-fullhd
  • .is-gapless for rows
  • .is-multiline
  • .is-centered for rows

Lack of documentation for Media Cards

Media cards are a component feature that are not documented in sgds website.

currently a makeshift documentation exists on
designsystem.gov.sg/testing/card/

Masthead font-size scaling question

hi there o/

just curious if padding and font-size use of px was intentional since height and max-height uses rem.

image

not sure if font-size scaling is still a thing required for government websites, if it is, then the design would look something like this (which seems rather off to me).

image

perhaps a fix to this is to use rem or convert everything to px so that it doesn't scale?

Responsive Issues on smaller phone sizes

Text are not fitting in boxes on components page, need to check if our media queries cover smaller sized screens.

image

There may be more of such instances of these broken responsive parts that we will need to fix.
In the event that we do not, we should try to cover for all screen resolutions (especially smaller ones!)

Changelog.md

Add and maintain a changelog.
Make sure to tag, refer to issues in commits, properly document PRs so we can use github_changelog_generator.

JS for notifications

If js is provided for accordion, tabs etc, notifications should have js as well. Easy implementation!

Implementation of button uses <a> instead of <button>

Taken from @Neurrone
Buttons are rendered using a tag, which should only be used for links. I suggest using an actual element instead.

This would cause confusion for screen reader users, since the expectation of a link is that it moves you to a new page of the application, while buttons update something within the same page. They will also be read as links, not buttons.
The disabled attribute will also not be read, since its not recognized on links, but is conveyed for buttons. The conditional if statement that executes the onclick handler will no longer be needed, since the browser prevents users from interacting with a

with the disabled attribute.
Links without valid hrefs are not keyboard focusable by default, the disabled jsx lint warns about this.
Add onFocus and onBlur events, which are roughly the keyboard equivalent of onMouseEnter and onMouseLeave so that keyboard users can also activate this functionality.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.