Git Product home page Git Product logo

gottsch-minecraft-dungeons2's People

Contributors

gottsch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

darkstrumn

gottsch-minecraft-dungeons2's Issues

Crash on world gen

MC Version: 1.12.2
Forge version: 1.12.2-14.23.0.2545

Sometimes when the world gen is happening the game will crash with this error. It seems to be due to a problem interacting with some biome but I'm not sure which. I do have mods that add biomes such Biomes of plenty so it may be related to that. I am finding dungeons so at lest some of them are loading.

If there is anything I can do to enable more detailed logging to determine which biome this is happening with I would be happy to do that.

`Description: Exception in server tick loop

java.lang.NoSuchMethodError: net.minecraft.world.biome.Biome.func_185359_l()Ljava/lang/String;
at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:240)
at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1016)
at net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:996)
at net.minecraftforge.common.chunkio.ChunkIOProvider.syncCallback(ChunkIOProvider.java:106)
at net.minecraftforge.common.chunkio.ChunkIOExecutor.tick(ChunkIOExecutor.java:150)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:725)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:396)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:665)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524)
at java.lang.Thread.run(Thread.java:748)
`

Crash creating single player world

As of Dungeons2-mc1.12.2-f14.23.1.2555-v1.3.3.jar, crash is reported when trying to create a single player creative world:

Description: Exception in server tick loop

java.lang.NullPointerException
    at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:265)
    at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
    at net.minecraft.world.chunk.Chunk.populate(Chunk.java:1018)
    at net.minecraft.world.chunk.Chunk.populate(Chunk.java:997)
    at net.minecraft.world.gen.ChunkProviderServer.provideChunk(ChunkProviderServer.java:157)
    at net.minecraft.server.MinecraftServer.initialWorldChunkLoad(MinecraftServer.java:344)
    at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:142)
    at net.minecraft.server.integrated.IntegratedServer.init(IntegratedServer.java:156)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:486)
    at java.lang.Thread.run(Unknown Source)

CTD -- NPE -- DungeonsWorldGen.generate -- Stylesheet default resources fail to initialize properly on first launch

crash-2022-07-29_17.41.29-server.txt
dungeons2.log

Steps to reproduce:

  1. Install a fresh Curse Modded Minecraft 1.12.2, Forge 14.23.5.2859 profile and install Dungeons2!, or Import the following profile:
    Dungeons2Test.zip
  2. Attempt to create a new, single-player world, with the seed: 1
  3. CTD

Note, CTD doesn't happen on subsequent launches of the same world, even after deleting the world and creating it again.
After a CTD, it doesn't seem that the dungeon at the spawn location effectively spawns. If you delete the world, then create a world with the same name and the seed (1), then the dungeon near the spawn does generate.

This led me to investigate the code further.
The Crash Log points to this:
at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:274)

Theme theme = styleSheet.getThemes().get(styleSheet.getThemes().keySet().toArray()[random.nextInt(styleSheet.getThemes().size())]);
// TODO create a custom exception to throw if theme is null/not found.

And the Dungeons2 Log points to this:
at com.someguyssoftware.dungeons2.style.StyleSheetLoader.exposeStyleSheet(StyleSheetLoader.java:249) [StyleSheetLoader.class:mc1.12.2-f14.23.5.2859-v1.7.6]

public static void exposeStyleSheet(String filePath) {
Path path = Paths.get(filePath).toAbsolutePath();
if (Files.notExists(path)) {
Dungeons2.log.error("Attempting to copy style to path -> {}", path.toString());
// TODO create folder
// copy from resource/classpath to file path
InputStream is = Dungeons2.instance.getClass().getResourceAsStream(StyleSheetLoader.BUILT_IN_STYLE_SHEET_PATH);
try (FileOutputStream fos = new FileOutputStream(path.toFile())) {
byte[] buf = new byte[2048];
int r;
while ((r = is.read(buf)) != -1) {
fos.write(buf, 0, r);
}
}
catch(IOException e) {
Dungeons2.log.error("Error exposing stylesheet resource to file system: ", e);
}
}
}

We know the try on L249 is failing, and we get this message:
java.io.FileNotFoundException: C:\Users\Twistedlink\Documents\Twitch\Minecraft\Instances\Dungeons2Test\mods\dungeons2\styleSheet.json (The system cannot find the path specified)

On a hunch, I created a second modpack, with an override to supply the contents of the mods/dungeons2 directory before first launch:
Dungeons2TestOverrides.zip

If you import and run this profile, things work as intended, suggesting there's an issue with the mod attempting to use these stylesheet resources before they're successfully initialized.

I don't have the time to dig further at the moment (I don't have a development environment set up to do mod development), and this overrides workaround works for me. Additionally, anyone running this mod for the first time will likely crash once, but on subsequent runs, will be fine. It hampers the initial user experience, but it isn't game-breaking, despite being a CTD.

Random Crash

So here's the random crash I got. Idk specifics, just one of my users exploring chunks when server died. As it hasn't died in a while, it was clearly a big surprise.

https://pastebin.com/akWn2X6c

Exception Ticking World

---- Minecraft Crash Report ----

WARNING: coremods are present:
llibrary (llibrary-core-1.0.11-1.12.2.jar)
TransformLoader (DynamicSurroundings-1.12.2-3.6.1.0.jar)
Inventory Tweaks Coremod (InventoryTweaks-1.63.jar)
OTGCorePlugin (OTG-Core.jar)
ItemPatchingLoader (ItemPhysic_Full_1.4.34_mc1.12.2.jar)
CreativePatchingLoader (CreativeCore_v1.10.16_mc1.12.2.jar)
ForgelinPlugin (Forgelin-1.8.4 (1).jar)
IvToolkit (IvToolkit-1.3.3-1.12.jar)
LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)
CTMCorePlugin (CTM-MC1.12.2-1.0.2.31.jar)
FutureMC (future-mc-1.12.2-0.2.4.1 (1).jar)
Contact their authors BEFORE contacting forge

// Who set us up the TNT?

Time: 11/23/20 11:03 PM
Description: Exception ticking world

java.lang.NullPointerException: Exception ticking world
at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:285)
at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1190)
at net.minecraft.world.chunk.Chunk.populateCB(Chunk.java:1149)
at net.minecraft.world.gen.ChunkProviderServer.func_186025_d(ChunkProviderServer.java:172)
at net.minecraft.server.management.PlayerChunkMapEntry.func_187268_a(PlayerChunkMapEntry.java:126)
at net.minecraft.server.management.PlayerChunkMap.func_72693_b(PlayerChunkMap.java:175)
at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:432)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:971)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:456)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:861)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:733)
at java.lang.Thread.run(Thread.java:748)

A detailed walkthrough of the error, its code path and all known details is as follows:

-- Head --
Thread: Server thread
Stacktrace:
at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:285)
at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1190)
at net.minecraft.world.chunk.Chunk.populateCB(Chunk.java:1149)
at net.minecraft.world.gen.ChunkProviderServer.func_186025_d(ChunkProviderServer.java:172)
at net.minecraft.server.management.PlayerChunkMapEntry.func_187268_a(PlayerChunkMapEntry.java:126)
at net.minecraft.server.management.PlayerChunkMap.func_72693_b(PlayerChunkMap.java:175)
at net.minecraft.world.WorldServer.func_72835_b(WorldServer.java:432)

-- Affected level --
Details:
Level name: BBOP
All players: 1 total; [EntityPlayerMP['SenZ0_'/714, uuid='c961ec2c-9277-4928-b6fa-d31e312f9bde', l='BBOP', x=-241.51, y=79.89, z=1240.46, cx=-16, cd=77, tl=28846, v=true, d=false](SenZ0_ at -241.51103206749414,79.89177229146699,1240.4555518693533)]
Chunk stats: ServerChunkCache: 683 Drop: 0
Level seed: -4613262245187854306
Level generator: ID 07 - OTG, ver 0. Features enabled: true
Level generator options: OpenTerrainGenerator
Level spawn location: World: (32,64,1020), Chunk: (at 0,4,12 in 2,63; contains blocks 32,0,1008 to 47,255,1023), Region: (0,1; contains chunks 0,32 to 31,63, blocks 0,0,512 to 511,255,1023)
Level time: 44848 game time, 58287 day time
Level dimension: 0
Level storage version: 0x04ABD - Anvil
Level weather: Rain time: 16831 (now: false), thunder time: 44326 (now: false)
Level game mode: Game mode: survival (ID 0). Hardcore: false. Cheats: false
Stacktrace:
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:971)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:456)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:861)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:733)
at java.lang.Thread.run(Thread.java:748)

-- System Details --
Details:
Minecraft Version: 1.12.2
Magma Version: 50f320e
Operating System: Linux (amd64) version 4.15.0-112-generic
Java Version: 1.8.0_275, Oracle Corporation
Java VM Version: OpenJDK 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 1823691240 bytes (1739 MB) / 3418357760 bytes (3260 MB) up to 9544663040 bytes (9102 MB)
JVM Flags: 2 total; -Xms128M -Xmx10240M
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
FML: MCP 9.42 Powered by Forge 14.23.5.2854 85 mods loaded, 85 mods active
States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored

| State  | ID                          | Version                  | Source                                           | Signature                                |
|:------ |:--------------------------- |:------------------------ |:------------------------------------------------ |:---------------------------------------- |
| LCHIJA | minecraft                   | 1.12.2                   | minecraft.jar                                    | None                                     |
| LCHIJA | mcp                         | 9.42                     | minecraft.jar                                    | None                                     |
| LCHIJA | FML                         | 8.0.99.99                | magma-server.jar                                 | None                                     |
| LCHIJA | forge                       | 14.23.5.2854             | magma-server.jar                                 | None                                     |
| LCHIJA | creativecoredummy           | 1.0.0                    | minecraft.jar                                    | None                                     |
| LCHIJA | itemphysic                  | 1.4.0                    | minecraft.jar                                    | None                                     |
| LCHIJA | ivtoolkit                   | 1.3.3-1.12               | minecraft.jar                                    | None                                     |
| LCHIJA | otgcore                     | 1.12.2 - v9.0            | minecraft.jar                                    | None                                     |
| LCHIJA | bspkrscore                  | 7.6.0.1                  | [1.12]bspkrsCore-universal-7.6.0.1.jar           | None                                     |
| LCHIJA | treecapitator               | 1.43.0                   | [1.12]TreeCapitator-client-1.43.0.jar            | None                                     |
| LCHIJA | advanced-fishing            | 1.3.3                    | Advanced-Fishing-1.12.2-1.3.3.jar                | None                                     |
| LCHIJA | antiqueatlas                | 4.6.3                    | antiqueatlas-1.12.2-4.6.3.jar                    | None                                     |
| LCHIJA | jei                         | 4.16.1.301               | jei_1.12.2-4.16.1.301.jar                        | None                                     |
| LCHIJA | appleskin                   | 1.0.9                    | AppleSkin-mc1.12-1.0.9.jar                       | None                                     |
| LCHIJA | aquaculture                 | 1.6.8                    | Aquaculture-1.12.2-1.6.8.jar                     | None                                     |
| LCHIJA | autoreglib                  | 1.3-32                   | AutoRegLib-1.3-32.jar                            | None                                     |
| LCHIJA | battletowers                | 1.6.5                    | BattleTowers-1.12.2.jar                          | None                                     |
| LCHIJA | baubles                     | 1.5.2                    | Baubles-1.12-1.5.2.jar                           | None                                     |
| LCHIJA | mujmajnkraftsbettersurvival | 1.4.1                    | better_survival-1.4.1.jar                        | None                                     |
| LCHIJA | bettercaves                 | 1.12.2                   | bettercaves-1.12.2-2.0.4.jar                     | None                                     |
| LCHIJA | bettercombatmod             | 1.5.6                    | BetterCombat-1.12.2-1.5.6.jar                    | None                                     |
| LCHIJA | betternether                | 0.1.8.6                  | betternether-0.1.8.6 (1).jar                     | None                                     |
| LCHIJA | bibliocraft                 | 2.4.5                    | BiblioCraft[v2.4.5][MC1.12.2].jar                | None                                     |
| LCHIJA | biomesoplenty               | 7.0.1.2444               | BiomesOPlenty-1.12.2-7.0.1.2444-universal.jar    | None                                     |
| LCHIJA | openterraingenerator        | v9.0                     | OpenTerrainGenerator-1.12.2-v9.0.jar             | None                                     |
| LCHIJA | bbop                        | 1.0                      | Biome_Bundle_O_Plenty-1.12.2_v1.0.jar            | None                                     |
| LCHIJA | bountifulbaubles            | 0.0.1                    | Bountiful Baubles-1.12.2-0.1.5.jar               | None                                     |
| LCHIJA | campfire                    | 1.2                      | campfire-1.12-v1.2.jar                           | None                                     |
| LCHIJA | carryon                     | 1.12.3                   | carryon-1.12.2-1.12.3.15.jar                     | fd21553434f4905f2f73ea7838147ac4ea07bd88 |
| LCHIJA | chameleon                   | 1.12-4.1.3               | Chameleon-1.12-4.1.3.jar                         | None                                     |
| LCHIJA | coralreef                   | 2.0                      | CoralReef-2.5-1.12.2.jar                         | None                                     |
| LCHIJA | crafttweaker                | 4.1.20                   | CraftTweaker2-1.12-4.1.20.586.jar                | None                                     |
| LCHIJA | crafttweakerjei             | 2.0.3                    | CraftTweaker2-1.12-4.1.20.586.jar                | None                                     |
| LCHIJA | creativecore                | 1.10.0                   | CreativeCore_v1.10.16_mc1.12.2.jar               | None                                     |
| LCHIJA | deadlyworld                 | 1.0.0_for_mc1.12.2       | deadlyworld-1.0.0_for_mc1.12.2.jar               | None                                     |
| LCHIJA | disenchanter                | 1.6                      | disenchanter-[1.12]1.6.jar                       | None                                     |
| LCHIJA | dldungeonsjbg               | 1.13.2                   | DoomlikeDungeons-1.13.2-MC1.12.2.jar             | None                                     |
| LCHIJA | gottschcore                 | 1.13.1                   | GottschCore-mc1.12.2-f14.23.5.2768-v1.13.1.jar   | None                                     |
| LCHIJA | dungeons2                   | 1.7.5                    | Dungeons2-mc1.12.2-f14.23.5.2768-v1.7.5.jar      | None                                     |
| LCHIJA | orelib                      | 3.6.0.1                  | OreLib-1.12.2-3.6.0.1.jar                        | 7a2128d395ad96ceb9d9030fbd41d035b435753a |
| LCHIJA | dsurround                   | 3.6.1.0                  | DynamicSurroundings-1.12.2-3.6.1.0.jar           | 7a2128d395ad96ceb9d9030fbd41d035b435753a |
| LCHIJA | enhancedvisuals             | 1.3.0                    | EnhancedVisuals_v1.3.18_mc1.12.2.jar             | None                                     |
| LCHIJA | mod_lavacow                 | 1.2.2                    | Fish's+Undead+Rising-1.2.2.jar                   | None                                     |
| LCHIJA | forgelin                    | 1.8.4                    | Forgelin-1.8.4 (1).jar                           | None                                     |
| LCHIJA | tschipplib                  | 1.1.4                    | tschipplib-1.12.2-1.1.4.jar                      | None                                     |
| LCHIJA | forgottenitems              | 1.2.1                    | ForgottenItems MC1.12.2 v1.2.1.jar               | None                                     |
| LCHIJA | futuremc                    | 0.2.4.1                  | future-mc-1.12.2-0.2.4.1 (1).jar                 | None                                     |
| LCHIJA | grapplemod                  | 1.12.2-v11.1             | grapplemod-v11.1-1.12.2.jar                      | None                                     |
| LCHIJA | waila                       | 1.8.26                   | Hwyla-1.8.26-B41_1.12.2.jar                      | None                                     |
| LCHIJA | llibrary                    | 1.7.19                   | llibrary-1.7.19-1.12.2.jar                       | b9f30a813bee3b9dd5652c460310cfcd54f6b7ec |
| LCHIJA | iceandfire                  | 1.7.1                    | iceandfire-1.7.1-1.12.2.jar                      | None                                     |
| LCHIJA | improvedbackpacks           | 1.12.2-1.5.0.0           | ImprovedBackpacks-1.12.2-1.5.0.0 (1).jar         | None                                     |
| LCHIJA | incontrol                   | 3.9.16                   | incontrol-1.12-3.9.17 (1).jar                    | None                                     |
| LCHIJA | infernalmobs                | 1.7.6                    | InfernalMobs-1.12.2.jar                          | None                                     |
| LCHIJA | inventorytweaks             | 1.63+release.109.220f184 | InventoryTweaks-1.63.jar                         | 55d2cd4f5f0961410bf7b91ef6c6bf00a766dcbe |
| LCHIJA | iseedragons                 | 0.12                     | ISeeDragons-0.12.jar                             | None                                     |
| LCHIJA | levelup2                    | ${version}               | Level Up! 2-1.1.23-1.12.jar                      | None                                     |
| LCHIJA | libraryex                   | 1.1.3                    | LibraryEx-1.12.2-1.1.3.jar                       | None                                     |
| LCHIJA | mobends                     | 1.0.0-beta-20.06.20      | MoBends_1.12.2-1.0.0-beta-20.06.20.jar           | None                                     |
| LCHIJA | multimob                    | 1.0.5                    | multimob-1.0.5.jar                               | None                                     |
| LCHIJA | naturescompass              | 1.8.5                    | NaturesCompass-1.12.2-1.8.5.jar                  | None                                     |
| LCHIJA | placebo                     | 1.6.0                    | Placebo-1.12.2-1.6.0.jar                         | None                                     |
| LCHIJA | potioncore                  | 1.9_for_1.12.2           | PotionCore-1.9_for_1.12.2.jar                    | None                                     |
| LCHIJA | potionfingers               | r1.0-2                   | PotionFingers-r1.0-2.jar                         | None                                     |
| LCHIJA | qualitytools                | 1.0.7_for_1.12.2         | QualityTools-1.0.7_for_1.12.2.jar                | None                                     |
| LCHIJA | reskillable                 | 1.12.2-1.13.0            | Reskillable-1.12.2-1.13.0.jar                    | None                                     |
| LCHIJA | additionalstructures        | 2.3.1                    | Rex's-Additional-Structures-1.12.x-(v.2.3.1).jar | None                                     |
| LCHIJA | roughmobsrevamped           | 2.3.19                   | roughmobsrevamped-1.12.2-2.3.19.jar              | None                                     |
| LCHIJA | roughtweaks                 | 1.0                      | roughTweaks0.2.4-1.12.2.jar                      | None                                     |
| LCHIJA | silentlib                   | 3.0.13                   | SilentLib-1.12.2-3.0.14+168.jar                  | None                                     |
| LCHIJA | scalinghealth               | 1.3.37                   | ScalingHealth-1.12.2-1.3.42+147.jar              | None                                     |
| LCHIJA | somanyenchantments          | 0.5.0                    | SoManyEnchantments-0.5.0.jar                     | None                                     |
| LCHIJA | spartanweaponry             | beta 1.3.8               | SpartanWeaponry-1.12.2-beta-1.3.8.jar            | None                                     |
| LCHIJA | spartanfire                 | 0.05                     | spartanfire-0.05.jar                             | None                                     |
| LCHIJA | spartanshields              | 1.5.4                    | SpartanShields-1.12.2-1.5.4.jar                  | None                                     |
| LCHIJA | spawnercontrol              | 1.6.3b                   | SpawnerControl-1.6.3b.jar                        | None                                     |
| LCHIJA | stg                         | 1.12.2-1.2.3             | stg-1.12.2-1.2.3.jar                             | None                                     |
| LCHIJA | stygian                     | 1.0.4                    | stygian-1.0.4.jar                                | None                                     |
| LCHIJA | toolbelt                    | 1.9.13                   | ToolBelt-1.12.2-1.9.13.jar                       | None                                     |
| LCHIJA | toroquest                   | 1.12.2-5.3               | ToroQuestRevamped-11-11-2020.jar                 | None                                     |
| LCHIJA | xat                         | 0.29.2                   | Trinkets and Baubles-1.12.2-0.29.2.jar           | None                                     |
| LCHIJA | villagenames                | 4.1.1                    | VillageNames-1.12.2-4.1.1.jar                    | None                                     |
| LCHIJA | waystones                   | 4.1.0                    | Waystones_1.12.2-4.1.0.jar                       | None                                     |
| LCHIJA | xpbook                      | v1.1.4                   | xptome-1.12.2-v1.1.4.jar                         | None                                     |
| LCHIJA | betteranimalsplus           | 9.0.1                    | betteranimalsplus-1.12.2-9.0.1.jar               | None                                     |

Loaded coremods (and transformers): 

llibrary (llibrary-core-1.0.11-1.12.2.jar)
net.ilexiconn.llibrary.server.core.plugin.LLibraryTransformer
net.ilexiconn.llibrary.server.core.patcher.LLibraryRuntimePatcher
TransformLoader (DynamicSurroundings-1.12.2-3.6.1.0.jar)

Inventory Tweaks Coremod (InventoryTweaks-1.63.jar)
invtweaks.forge.asm.ContainerTransformer
OTGCorePlugin (OTG-Core.jar)
com.pg85.otg.forge.asm.excluded.OTGClassTransformer
ItemPatchingLoader (ItemPhysic_Full_1.4.34_mc1.12.2.jar)
com.creativemd.itemphysic.ItemTransformer
CreativePatchingLoader (CreativeCore_v1.10.16_mc1.12.2.jar)

ForgelinPlugin (Forgelin-1.8.4 (1).jar)

IvToolkit (IvToolkit-1.3.3-1.12.jar)

LoadingPlugin (Reskillable-1.12.2-1.13.0.jar)
codersafterdark.reskillable.base.asm.ClassTransformer
CTMCorePlugin (CTM-MC1.12.2-1.0.2.31.jar)
team.chisel.ctm.client.asm.CTMTransformer
FutureMC (future-mc-1.12.2-0.2.4.1 (1).jar)
thedarkcolour.futuremc.asm.CoreTransformer
Profiler Position: N/A (disabled)
Player Count: 1 / 21; [EntityPlayerMP['SenZ0_'/714, uuid='c961ec2c-9277-4928-b6fa-d31e312f9bde', l='BBOP', x=-241.51, y=79.89, z=1240.46, cx=-16, cd=77, tl=28846, v=true, d=false](SenZ0_ at -241.51103206749414,79.89177229146699,1240.4555518693533)]
Is Modded: Definitely; Server brand changed to 'Magma'
Type: Dedicated Server (map_server.txt)

Cascading Worldgen Lag

[13:42:03] [Server thread/WARN] [FML]: GottschCore loaded a new chunk (1, 44 Dimension: 0) during chunk population, causing cascading worldgen lag. Please report this to the mod's issue tracker. This log can be disabled in the Forge config.

It is actually Dungeons2 that is causing the cascading worldgen.

Fix Entrance Generation

The current entrance building rarely generates properly with all decorations. It usually looks like a decayed box.

[feature request] Allow configuring dungeons to use Minecrafts loot tables instead

People rarely play with only a few mods. Other mods often add their loot drops to game's chest loot tables.

Default Dungeons2 chest loot tables are configured with vanilla in mind. Changing them to accommodate loot from every other mod is a tedious and cumbersome task. Instead of configuring Dungeons2 chest tables, it would be much better, if we could instead configure it to use loot tables that are defined by the game and modified by other mods. For example, ["chest/dungeon", "chest/mineshaft"], for starters.

Or at least add a command that would generate Dungeons2 loot tables based on game loot tables...

Put config files in minecraft/config

Modpack devs can't ship a custom configuration for your mod if the configs generate in /mods. I won't even look at a dungeon mod if I can't customize the loot tables.

Might be me but aren't spawners a bit rare in the dungeon?

Every level seems to have like... what, 2 spawners tops? It's really odd to see so few spawners, really makes me feel like the dungeon could be so much more challenging. Maybe a config option for min/max spawners per level would be a nice addition, or did I just miss something in the config?

[GameBreaking BugReport] Dungeon spawner is fundationally broken. [Pregenerator]

Hello,

So I got a bug report with ChunkPregenerator that my mod seems to cause your mod to spawn dungeons only in spawn chunks...

I looked at your code and found this:

dungeonBoundary = getDungeonBoundary(spawnCoords, closestCoords);

To explain what this is:
After the mod has decided by a "Global counter" in a deterministic world generator (effectively random) that it should generate a dungeon.
Instead of Generating this Dungeon in the chunk that was decided on, you instead try to pick the closest player or spawn if none found and shift that 128 blocks towards the generated chunk (from decided player/spawn location) and spawn the dungeon there...

After reading the config and seeing that dungeons only need to be 17-18 blocks away from each other +- structure bounds i found out that this can be exploited since there is a "global" chunk counter. So if you are a bit crazy you the player could decide where exactly these dungeons spawn...

For anyone who wonders. Any pregenerator will cause this issue because either the player is present or not and will forcefully drag all dungeons to themselves or spawn will attract them... But this is not the Pregenerators fault. Its Dungeons 2 fault.

Generation conflict with Galacticraft

Not pointing a finger here, necessarily, but the crash report is pretty clear that there's something not playing nicely between this and GC. I can't verify that there have been instances where generation has occurred successfully because I don't know what might be broken, but I have seen this exact crash 7-8 times this morning and it is resolved by removing either Dungeons2 or Galacticraft. Note that this is a pregen process for DIM0, not a GC dimension.

Posted on GC tracker as well: micdoodle8/Galacticraft#3200

MicdoodleCore-1.12.2-4.0.1.139
GalacticraftCore-1.12.2-4.0.1.139
GottschCore-mc1.12.2-f14.23.1.2555-v1.2.0
Dungeons2-mc1.12.2-f14.23.1.2555-v1.3.2
forge-1.12.2-14.23.2.2619-universal

at com.someguyssoftware.dungeons2.worldgen.DungeonsWorldGen.generate(DungeonsWorldGen.java:240)
at net.minecraftforge.fml.common.registry.GameRegistry.generateWorld(GameRegistry.java:167)
at micdoodle8.mods.galacticraft.core.TransformerHooks.otherModGenerate(TransformerHooks.java:183)
at net.minecraft.world.chunk.Chunk.func_186034_a(Chunk.java:1016)
at net.minecraft.world.chunk.Chunk.func_186030_a(Chunk.java:977)
at pregenerator.impl.processor.ChunkFile.populate(ChunkFile.java:86)
at pregenerator.impl.processor.ChunkFile$ChunkFileEntry.process(ChunkFile.java:250)
at pregenerator.impl.processor.ChunkProcessor.onServerTickEvent(ChunkProcessor.java:97)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_381_ChunkProcessor_onServerTickEvent_ServerTickEvent.invoke(.dynamic)
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:179)
at net.minecraftforge.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:265)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:710)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:524)
at java.lang.Thread.run(Unknown Source)

Compatibility with Mods that modify Spawners and Loot Tables

I use a lot of mods like Lycanites Mobs and Dungeon Tactics which modify the vanilla spawners and loot tables. Because of this for example, you can find Lycanites Mobs appearing in Dungeon Tactics' towers and custom loot items in all vanilla dungeons and chest as well. Is there a way to add similar compatibility without having to create custom spawn and chest sheets? An option to use the modified vanilla spawners and loot tables instead of the custom sheets?

Default Loot support for most common mods

Would it be possible for you to have your mod check for the most common/popular large mods and utilize default loot tables for them if they are present? For example, Thermal Expansion suite, Mekanism, Astral Sorcery, Actually Additions, etc.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.