Git Product home page Git Product logo

ivi's People

Contributors

matthewrankin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ivi's Issues

Refactor New for E36xx to handle different types of DCPwr instruments

If a single driver is going to handle multiple models, I'll need to implement one or possibly multiple of the following new functions:

  1. Have specific new functions for each supported model, such as NewE3631A(inst) instead of New(inst)
  2. Have a NewQuery(inst) function that queries the instrument and confirms it is supported.
  3. Have a New(inst, model) function that specifies the model of the instrument to create.

In all of these, how do I handle passing in an option to reset the device? Is that always a boolean that is provided? What if I want to specify NewE3631A(inst) and I also want to query the device to ensure it actually that? I could simply mandate that a query is always performed.

Make command line terminator a variable

Right now all SCPI command strings include \n as the command line terminator. What if an instrument doesn't expect a newline as the SCPI terminator? For the Prologix GPIB, the line terminations are stripped by the GPIB controller and then a terminator is added based on the ++eos command setting.

One option is to include a terminator that can be set for the instrument instead of just hardcoding \n. Ideally the IVI driver has the proper line terminator for that driver. Although, I don't know if the line termination could need to change for the same piece of test equipment based on the interface used to communicate (i.e., GPIB vs LXI vs ASRL vs USBTMC).

Add timeouts

Need to have timeouts for connecting to devices using VISA or directly using LXI or USBTMC. This might be something that needs to be added to the other packages.

Add ability to query ID when creating a new instrument

Section 6.16 Initialize in IVI-3.2: Inherent Capabilities Specification states that the Initialize function has an IdQuery boolean parameter that queries the instrument for its ID (*IDN?) and verifies that the IVI specific driver supports the particular instrument model.

Replace Instrument interface with io.ReadWriter interface

Should we replace the Instrument interface with io.ReadWriter interface? Stated differently, do we really need the StringWriter and Querier interfaces?

type Instrument interface {
	Read(p []byte) (n int, err error)
	Write(p []byte) (n int, err error)
	StringWriter
	Querier
}

type StringWriter interface {
	WriteString(s string) (n int, err error)
}

type Querier interface {
	Query(s string) (value string, err error)
}

I think the only reason I'm using the StringWriter and Querier interfaces is to handle automatically adding the command termination. Is that true? What about using the Prologix GPIB controller? Would that work without the StringWriter and Querier interfaces?

Add option to reset when creating new instrument

The signature for the New function should be changed from New(address string) to New(address string, reset bool) so that users can select whether or not to reset the device when creating a new IVI instrument.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.