What

I am trying to use static analysis to detect functions that do not call "Close". But I found an issue in CalledFrom function.

CalledFrom function can correctly detects that the case (1) is NG.

case (1):

func f() {
	client.ReadOnlyTransaction()   // want "NG"
}

However, in the case (2), the function cannot correctly detects that it is NG.

case (2):

func f() {
	os.Open("xxx") //want "NG"
}

Why

In the CalledFrom function, identical function is called to compare receiver (types.Pointer type) and the return value of called funtion (eg. os.Open()).

In the case (1), client.ReadOnlyTransaction() returns only one value, so the type of return value is (types.Pointer).

However, in the case (2), os.Open() returns two values, so the type of return value is (types.Tuple).

Because of them, CalledFrom cannot correctly detects the case (2) is NG.

I was recently trying to use analysisutil.CalledFrom instead of the example in sqlrowsutil. However this does not work as expected. analysisutil seems to be close, but not the exact behavior as sqlrowsutil. Is this expected? The godocs and signatures exactly match, so the assumption is their behavior would match as well.

https://github.com/gostaticanalysis/sqlrows/blob/master/sqlrowsutil/util.go#L199
https://github.com/gostaticanalysis/analysisutil/blob/v0.7.1/call.go#L397

call_test.go does not work.

analysisutil.MethodOf(pass, mytype, "method") // return nil

MethodOf should not use (*types.Func).Id to compare the name instead of (*types.Func).Name.