gorse-io / gorse4j Goto Github PK

A minor optimization for CI can be to use Apache Maven Daemon rather than the plain mvn commands for building.

This should be a drop in replacement, and provide faster CI (not the daemon providing any benefit but rather the fast, concurrent downloading from repositories).

This will be contributed as part of #1.

sign-maven-plugin allows users on all platforms to build the project agnostically. It works the same as maven-gpg-plugin and will allow you to deploy the way you are doing so already.

This will also create the following diff for the README (after #1):

- 56   # Building
- 57   When building on a Windows platform (or anywhere where GPG is not installed, *nix systems tend to bundle GPG), you should pass the `-Dgpg.skip` argument to Maven (`mvnd clean install -Dgpg.skip`).

Motivation

Almost every Java 9+ developer is using JPMS for the performance and development benefits it brings.

Approaches

This can be tackled in two different ways - Automatic-Module-Name in the MANIFEST.MF, in order to secure the name that would be used if JPMS is adopted in the future, or a module-info file to do this the correct way and actually use JPMS in the development of gorse4j as well.

I have done the latter in #1., but that is a controversial PR.