googleinterns / ad-lib Goto Github PK

The current code parses the POST request body all within the AddParticipantServlet doPost method. This issue would help in modularization of this processing and convert the JSON object into a POJO

Currently, the user is able to submit a form while leaving certain fields empty. Since all fields are needed to correctly identify a match, we should try to require all fields to be completed for form submission to be successful

If a user opts to save preferences, add user to datastore with saved preferences

Comment on PR by Kevin:
"A potential cleanup for a future PR could be to make this constructor private and instead use public factory methods to create participants. Some of the code that calls this now has to specify fields that don't make sense for their particular case. For example, creating a new unmatched participant requires the caller to explicitly include the MatchStatus and a zeroed out match ID. Not only does this lead to more LOC, but it also leaks a small detail that 0 is this class' default value for matchId.

A factory method might look like

  return new Participant(username, startTimeAvailable, endTimeAvailable, /* matchId= */ 0, MatchStatus.UNMATCHED, timestamp)
}```
which requires two fewer arguments because an unmatched participant will always have the unmatched enum value and zeroed match ID."

Currently, the frontend and backend are not communicating match status, but once this communication is established, instead of using alert to communicate to the user, a page redirection should be used instead.

AddParticipantServlet#doPost parses parameters from the request while it's processing. This could lead to wasted work if one of the request parameters is invalid. Unless all parameters are valid, the servlet should return early and return an error code to the frontned.

Once a user opts to save preferences, a User entity that can be updated is added to datastore. However, we never give the user an option to delete their preferences from the datastore even though they have the option to not save their current preferences.

Currently, only one participant in a match receives a "Matched" status, so this issue needs to be fixed

The frontend components are currently not tested and adding snapshot tests would help ensure that the UI does not change unexpectedly.

Match: display meeting details
NoMatch: Display expired participant details

Currently, the doPost method is not unit tested, however to ensure correct functionality and improve backend scalability/processes, unit tests should be added

Our current implementation uses the java DateTimeZone however the calendar API requires the DateTime class , so in order to connect the matching algorithm to the notification and event calendar we would need to switch the two

Right now, a User only includes a user's username if they choose to save their preferences. The User object should include fields for a user's role, PA, and interests.

Figure out when to null out participant's availability once their endTimeAvailable - (duration + PADDING) time passes.

Current ideas:

• Every 1 min, send out a request for each participant to see if the participant should be removed as a participant who's currently searching for a match (1 min is fine because of the 15 min padding)
• Continuously have the entire participant datastore searched