Draft Email for Intent to Deprecate is broken about chromium-dashboard HOT 3 CLOSED

I backfilled the gates on staging and prod.

You should now see gates for Enterprise, Debuggability, Testing, and API Owners. The button to generate the email is now part of the API Owners gate and it should work.

There is also a coding error in the case where there is a legitimate gate-less action, for example "Draft Ready for Developer Testing email". I will send a PR for a fix, and try to get it into our next release.

from chromium-dashboard.

I can repro this on some deprecation feature entries on staging.

I think the root cause is that in #3659 I added gates and this action to this stage, but we did not backfill gates on existing feature entries. That by itself is OK because the feature owners of existing deprecation feature entries could continue to generate these emails by hand like they were doing before my PR. For those old feature entries, the action button to generate the email would not have been displayed anywhere because the gate that it was part of did not exist on those feature entries.

However, the button became visible to users after #3773 merged. That PR displays buttons for actions on stages that have no gates. It should not display this button because that stage should have gates.

Possible solutions:

• BEST: Backfill gates on the plan stage of old deprecation feature entries
• Add logic to not show this particular action button even though it looks like a gate-less stage action.
• Allow the owners of old deprecations to generate the email without gates, which would be a confusing mix of old and new processes.

from chromium-dashboard.

Since it sounds like there should have been a gate, any idea which gate I missed that I should be going through before I click this button?

from chromium-dashboard.