Git Product home page Git Product logo

Comments (4)

jrobbins avatar jrobbins commented on September 27, 2024 1

Yep, I did the disconnection via pantheon and advised the feature owner as to their next steps on the blink-dev thread.

from chromium-dashboard.

jrobbins avatar jrobbins commented on September 27, 2024 1

The feature owner reported that the feature entry was back in the initial broken state today.
I investigated further and looked at the code for /cron/associate_origin_trials.

That code seems to correctly look for an existing OT stage that is already associated with the origin trial before trying to associate another stage on the same feature with that origin trial. So, it should not have reverted back to the broken state.

I looked at the datastore entries and found that the existing OT stage had the origin_trial_id set to the correct value but with type TEXT. That is not right because TEXT fields are not indexed and will not be found by the cron job when it searches for existing associated OT stages. It should be type STRING. I don't see anything in the code that ever used type TEXT. So, perhaps this was the result of a previous manual datastore edit.

In the pantheon UI, I set the value type to STRING and checked the checkbox to index it. After that, I ran the cron job twice and verified that it had correctly not associated the 3rd OT stage with the existing OT. This left the "Request Trial Creation" button available for the feature owner to press. I responded to the blink-dev thread again to explain and ask the feature owner to use the button.

from chromium-dashboard.

past avatar past commented on September 27, 2024

Assuming the problem here stems from the same cause as #3910, maybe we don't need any further investigation. @jrobbins can you disconnect the existing trial from the 3rd OT stage so that the owner can request a new trial creation?

from chromium-dashboard.

jrobbins avatar jrobbins commented on September 27, 2024

The user was able to request their new V3 OT.

from chromium-dashboard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.