core-shared-lib

This element is compatible with Polymer 0.5 and lower only, and will be deprecated.
You can check out a similar 0.8-compatible version of this element at https://github.com/polymerelements/iron-jsonp-library

core-shared-lib's People

Contributors

Stargazers

Watchers

core-shared-lib's Issues

Add a description in the GitHub repository

No script to insert before

in core-shared-lib.html

addScript: function (src) {
                    var script = document.createElement('script');
                    script.src = src;
                    script.onerror = this.error.bind(this);
                    var s = document.querySelector('script');
                        s.parentNode.insertBefore(script, s);
                    this.script = script;
                }

In certain situations "s" will be null, was bitten by this and was able to fix it by checking s and inserting into the body.

addScript: function (src) {
                    var script = document.createElement('script');
                    script.src = src;
                    script.onerror = this.error.bind(this);
                    var s = document.querySelector('script');
                    if (s)
                        s.parentNode.insertBefore(script, s);
                    else
                        document.body.appendChild(script);
                    this.script = script;
                }

Add a core-shared-lib-error event

The component has an error event listener on the <script> that gets loaded, but that error listener is just used to trigger cleanup(). It would be nice if this element fire()d a core-shared-lib-error event indicating when there was a failure to load, to go along with the event it fires when loading is complete.