Comments (3)
I was also wondering if it's a good idea to keep all these crates hidden?
#[doc(hidden)]
pub extern crate bincode;
#[doc(hidden)]
pub extern crate futures;
#[doc(hidden)]
pub extern crate serde;
#[doc(hidden)]
pub extern crate tokio_core;
#[doc(hidden)]
pub extern crate tokio_proto;
#[doc(hidden)]
pub extern crate tokio_service;
Because, for instance, in the README (for futures), it implies you need to add futures
and tokio_core
crates to your own package, when really you could just do:
use tarpc::futures::{self, Future};
use tarpc::tokio_core::reactor;
I don't see any harm in exposing these.
from tarpc.
I think it's typically not considered idiomatic to publicly export dependencies. The only reason I do it here is because it's the only way to guarantee that the macro-generated code compiles (I wouldn't want to rely on users having all the required extern crate
s).
from tarpc.
To add to that, if macros ever gain a way to use crates not publicly externed by its own crate, then I wouldn't want it to be a breaking change to change the current public crates to private (I'm pretty sure semver is ok with removing a public-but-hidden item).
from tarpc.
Related Issues (20)
- log spammed with `OpenTelemetry subscriber not installed; making unsampled child context` when used w/o Otel HOT 3
- Clippy Warnings in `tarpc`
- Example code only seems to work if I change the server to use ipv4 HOT 6
- Sending from multiple sources to a memory server
- Server acting as a client to another server HOT 5
- On `poll_flush` timing of RPC client and server HOT 3
- Forward thinking discussion on static async support HOT 2
- Removing the dependency on tokio HOT 3
- No error details when exceeding of LengthDelimitedCodec's max frame length HOT 6
- use qualified paths for all macro generated signatures HOT 1
- Why is it called tarpc? HOT 2
- How to save transport context? HOT 24
- Multi-client requests HOT 2
- Bidirectional RPC HOT 3
- Cross Platform Procedure Call HOT 2
- [FEATURE REQUEST] Stream responses HOT 4
- QUESTION: how to get tcp server features for custom transport? HOT 1
- Consider making tracing optional HOT 8
- Bubble up server side transport errors to the client HOT 5
- Design problem, how to call other structs method ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tarpc.