Git Product home page Git Product logo

Comments (3)

compressed avatar compressed commented on May 5, 2024

I was also wondering if it's a good idea to keep all these crates hidden?

#[doc(hidden)]
pub extern crate bincode;
#[doc(hidden)]
pub extern crate futures;
#[doc(hidden)]
pub extern crate serde;
#[doc(hidden)]
pub extern crate tokio_core;
#[doc(hidden)]
pub extern crate tokio_proto;
#[doc(hidden)]
pub extern crate tokio_service;

Because, for instance, in the README (for futures), it implies you need to add futures and tokio_core crates to your own package, when really you could just do:

use tarpc::futures::{self, Future};
use tarpc::tokio_core::reactor;

I don't see any harm in exposing these.

from tarpc.

tikue avatar tikue commented on May 5, 2024

I think it's typically not considered idiomatic to publicly export dependencies. The only reason I do it here is because it's the only way to guarantee that the macro-generated code compiles (I wouldn't want to rely on users having all the required extern crates).

from tarpc.

tikue avatar tikue commented on May 5, 2024

To add to that, if macros ever gain a way to use crates not publicly externed by its own crate, then I wouldn't want it to be a breaking change to change the current public crates to private (I'm pretty sure semver is ok with removing a public-but-hidden item).

from tarpc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.