On `poll_flush` timing of RPC client and server about tarpc HOT 3 CLOSED

Hi! Thanks for the kind words 😊

Thank you for pointing this out! I think it's a great suggestion to flush less frequently. Please send a PR!

from tarpc.

Looking more closely, I think this is the problem line: https://github.com/0x5459/ext-proc-channel/blob/85a8f275d0e0ff3e517d1a96bef5ab3ac27a89e4/src/client.rs#L269 because it doesn't check if the transport is ready for a request to be buffered.

start_send returns an Err when the write buffer is full, which means we need to flush, right? Otherwise the channel could spuriously fail.

The ensure_writeable fn doesn't always flush; it tries to only flush when the transport's buffer is full.

from tarpc.

Looking more closely, I think this is the problem line: https://github.com/0x5459/ext-proc-channel/blob/85a8f275d0e0ff3e517d1a96bef5ab3ac27a89e4/src/client.rs#L269 because it doesn't check if the transport is ready for a request to be buffered.

start_send returns an Err when the write buffer is full, which means we need to flush, right? Otherwise the channel could spuriously fail.

The ensure_writeable fn doesn't always flush; it tries to only flush when the transport's buffer is full.

I'm sorry. You're right. Great code!

from tarpc.