Consider new constructor functions for Client about tarpc HOT 8 CLOSED

We're going to be adding more configuration options as other changes land (to support more transports and making it generic over serialization protocol) so the Duration arg is probably going to turn into a config struct. So in the case where you want to just use the defaults it'll probably look like Client::new("1.2.3.4:0", Config::default()), which I think will be a readability improvement.

from tarpc.

Or perhaps fn new<A: ToSocketAddr>(address: A) -> Client; and fn from_config<A: ToSocketAddr>(config: Config<A>) -> Client;

from tarpc.

One other option would be config.create(), though this is slightly less discoverable.

from tarpc.

Maybe it would be interesting to consider the builder pattern, like used in Piston (see WindowSettings).

from tarpc.

I don't personally think the builder pattern is useful in this case. I think functional struct updates are equivalent. I think the builder pattern makes sense when there's some amount of work to perform when adding each param, but for this config it will simply connect after all params are set.

from tarpc.

That sounds appealing to the Haskeller in me 😄 . Shall I close this issue?

BTW, I left a question on reddit.

from tarpc.

Let's keep this issue open for reference. I'll probably convert to use a config struct pretty soon (I would also accept a PR if you're interested).

from tarpc.

Unfortunately I won't have time to do this in the short term, so go ahead. I hope to be able to help in the future, though.

from tarpc.