google / supersonic Goto Github PK

Apparently, there is a missing call to "autogen.sh" inside 
"install_supersonic.sh" script.

Pushed trivial fix into a separate branch in my clone - 
https://code.google.com/r/wojtekzozlak-supersonic/source/detail?r=6587b3edc9dba6
1ad8f4ebb9551f4744e25b5af8&name=installation-fix .

The gcc builtin uses a lookup table but it is possible to do better.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36041 - existing gcc bug for 
improving the builtin popcount. 

https://groups.google.com/group/comp.arch/msg/ba28c5dbd47a3bba?dmode=source&outp
ut=gplain&noredirect&pli=1 - this post by Terje Mathisen describes the technique

What steps will reproduce the problem?
1. ./autogen.sh
2. ./configure
3. make

What is the expected output? What do you see instead?

Make returns the following error:

mv -f .deps/libsupersonic_la-stack_trace.pb.Tpo 
.deps/libsupersonic_la-stack_trace.pb.Plo
mv: rename .deps/libsupersonic_la-stack_trace.pb.Tpo to 
.deps/libsupersonic_la-stack_trace.pb.Plo: No such file or directory
make[1]: *** [libsupersonic_la-stack_trace.pb.lo] Error 1
make: *** [all] Error 2

What version of the product are you using? On what operating system?

supersonic 0.9.1
Mac OS X 10.6.8

Please provide any additional information below.

I guess that this line in the Makefile is supposed to generate the missing file:

$(LIBTOOL)  --tag=CXX $(AM_LIBTOOLFLAGS) $(LIBTOOLFLAGS) --mode=compile $(CXX) 
$(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) 
$(libsupersonic_la_CXXFLAGS) $(CXXFLAGS) -MT libsupersonic_la-stack_trace.pb.lo 
-MD -MP -MF $(DEPDIR)/libsupersonic_la-stack_trace.pb.Tpo -c -o 
libsupersonic_la-stack_trace.pb.lo `test -f 
'supersonic/utils/exception/stack_trace.pb.cc' || echo 
'$(srcdir)/'`supersonic/utils/exception/stack_trace.pb.cc

However, for whatever reason $(DEPDIR)/libsupersonic_la-stack_trace.pb.Tpo is 
never created, so the next line fails:

$(am__mv) $(DEPDIR)/libsupersonic_la-stack_trace.pb.Tpo 
$(DEPDIR)/libsupersonic_la-stack_trace.pb.Plo

I don't really know anything about autoconf, but I'm guessing this has 
something to do with the fact that we're using the BSD libtool (glibtool on Mac 
OS X) rather than the GNU libtool.

It looks like supersonic/cursor/infrastructure/iterators.h includes another 
header cursor_transformer.h that does not get installed by default, so if you 
build against the system installed supersonic it complains of missing header.

What steps will reproduce the problem?

1. Clone the git repo
2. Install all required dependencies
3. Run autogen.sh

What is the expected output? What do you see instead?

./autogen.sh: line 16: libtoolize: command not found

What version of the product are you using? On what operating system?
 supersonic 0.9.1
Mac OS X 10.6.8

Please provide any additional information below.

Apparently this occurs because 'libtoolize' is called 'glibtoolize' on OS X. I 
worked around this by creating a symlink 'libtoolize' to glibtoolize.

What steps will reproduce the problem?
1.prepare all the deps...glog, gflags...
2.configure 
3.make

What is the expected output? What do you see instead?
make will be success.

What version of the product are you using? On what operating system?
ubuntu 
Please provide any additional information below.
./supersonic/utils/atomicops-internals-x86.h: In function ‘void 
base::subtle::SpinLockDelay(volatile Atomic32*, int32, int)’:
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm7’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm6’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm5’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm4’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm3’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm2’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm1’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:421:67: error: unknown register 
name ‘mm0’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm7’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm6’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm5’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm4’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm3’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm2’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm1’ in ‘asm’
./supersonic/utils/atomicops-internals-x86.h:398:67: error: unknown register 
name ‘mm0’ in ‘asm’

What steps will reproduce the problem?

char a[] = {0, 0, 0, 0x80};
char b[] = {0, 0, 0, 0x01};

assert(fastmemcmp_inlined(a, b, 4) == memcmp(a, b, 4));

What is the expected output? What do you see instead?

memcmp is supposed to be bytewise lexicographic comparison, but there is a bug 
in the inlined implementation:

  while (a < a_limit) {
    int d = static_cast<uint32>(*a++) - static_cast<uint32>(*b++);
    if (d) return d;
  }

incorrectly upcasts from 'const char *' to uint32, which has sign-extension 
behavior.

The arguments here should probably be made into const void * to match the 
signature of memcmp.

What version of the product are you using? On what operating system?
68c456e59482a26c595a9f4c5cc3d661e56a21b0

What steps will reproduce the problem?
1. make
2.
3.

What is the expected output? What do you see instead?
supersonic/expression/core/string_bound_expressions.cc:256:40: error: taking 
address of temporary [-fpermissive]


What version of the product are you using? On what operating system?
supersonic-0.9.0, compiler: gcc4.6

Please provide any additional information below.

What steps will reproduce the problem?
1. git status after running ./configure && make
2.
3.

What is the expected output? What do you see instead?
Build libraries and a lot of other generated files should be ignored by git.

Please use labels and text to provide additional information.

What steps will reproduce the problem?
1. Running ./configure on a platform with gcc 4.6.*
2.
3.

What is the expected output? What do you see instead?
Should build seamlessly, throws an 'unrecognized -R option' into config.log 
when running ./configure

Please use labels and text to provide additional information.

The test code of supersonic need to include boost timer, and boost timer rely 
on boost system. when building supersonic, it got an error like below

/usr/bin/ld: ./.libs/libsupersonic.a(libsupersonic_la-file_util.o): undefined 
reference to symbol 'boost::system::system_category()'
/usr/bin/ld: note: 'boost::system::system_category()' is defined in DSO 
/usr/lib/libboost_system.so.1.51.0 so try adding it to the linker co\
mmand line
/usr/lib/libboost_system.so.1.51.0: could not read symbols: Invalid operation
collect2: ld returned 1 exit status
make[1]: *** [supersonic_unittest] Error 1
make[1]: Leaving directory `/home/min/code/supersonic'
make: *** [all] Error 2

I modified  Makefile.am and it passed the building. 

It looks like shared_ptr is not defined in any kind of namespace. So when I'm 
trying to integrate supersonic into an existing code base I get errors about 
shared_ptr being redefined. In this case existing code already says "using 
std::shared_ptr"