Update popularity listing on main dashboard about site-kit-wp HOT 5 CLOSED

Implementation brief review: since Search Console API results sorted by click count descending, there isn't need to query more rows and hack the ordering which we are currently doing. We can get rid of the current hack, render a clicks column and simply query the top 10 results.

from site-kit-wp.

@adamsilverstein Do you happen to have any background on why page-analytics exists? It appears to do exactly the same as sc-site-analytics. Same about index-status, it doesn't appear to be used at all? Was it at some point, what was this datapoint meant for?

from site-kit-wp.

As you mentioned, page-analytics and sc-site-analytics are currently duplicates, I agree we can safely remove one now.

I did a little git spelunking and found that originally these were two separate similar but distinct data points - one for site wide data and one for page URL specific data:

from site-kit-wp.

QA ✅

from site-kit-wp.

This overall LGTM. Will only note that when all clicks are 0 it looks slightly weird, but is technically correct. We can consider an alternative display down the road if users get confused.

from site-kit-wp.