Looks like the tag searching code is search a null value. Probably not a functionality breaking bug, however worth fixing.

The error occurs here:

This is a regression and likely broke when we changed how/when the tag detecting iframe is loaded.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix console error on settings page while checking for existing analytics tag

Acceptance criteria

• No console errors should show on the settings page.

hello their, nice plugin, thx for the effort 🤚

i am having troubles getting this plugin working, using the plugin + the dev helper plugin.

my backend is on a different domain than my frontend, and to make it even harder my frontend is not built with WP - it is build with symfony using wp-json as a datasource (in a nutshell).

SearchConsole integration works, however, Analytics, Ads and the others do not work, havent yet full understanding of the process, it seems to try verify my analytics account with navigating to the frontend appending tagverify=1 - the first thing that happens is a CORS error (due to domain and stuff).

but even if the cors works (tested locally) it fails, due to the fact that my frontend, has no clue about the ?tagverify=1

my concrete questions:

• can i somehow just set the UA-profile ids?
  • because in fact my account is allowed to access GA data.
• is there any plan to move that to a "serviceaccount" based integration?
  • we don't want to have all of our editors (100+) to have to sign in with google 👍

thx - really looking forward to it!

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Describe the bug
Readme say that is compatible with WP 4.7 but doesn't seems.

I think that is looking for JS stuff that are available only after 5.0

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

The default GA snippet implementation doesn't add the option to anonymise IP addresses, which is required in some countries, for example the EU.

For all cases where Site Kit places the GA snippet on behalf of the user, we should enable this by default. (Site Kit can't update the snippet for sites where it was already placed via another plugin or other method.)

Steps to QA

Ensure the functionality in the AC/IB works, but it's worth additional QA on an existing site that upgrades to this functionality, because it introduces a new setting with a default.

1. Create/use an existing site with Analytics enabled before updating to a version of the plugin with this commit.
2. Ensure the HTML/analytics tag output does not include "anonymize_ip":true
3. Update the version of the plugin to one with this change.
4. Check the HTML source; it should now include "anonymize_ip":true

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

For cases where there is no pre-existing GA snippet detected on the site and the user decides to let Site Kit place the GA snippet on their behalf, check if the site is primary AMP.

• If yes, no need for further action.
• If not:
  • When placing the snippet, add the anonymize_ip parameter to anonymise IP addresses (details here)
  • In the Analytics settings section, add a toggle (on by default) with the text "Anonymise IP address".

Implementation Brief

• Add a toggle (on by default) to enable "Anonymize IP" functionality in assets/js/modules/analytics/setup.js with the text:

<Switch label={ __( 'Anonymize IP Address', 'google-site-kit' ) } />
<p>{ __( 'IP addresses will be anonymized.', 'google-site-kit' ) }</p>

• The above switch should only be available on the change/edit screens—not during setup.
• Add a setting to the Modules/Analytics.php code for anonymizing IP addresses. This should be enabled by default on updates to respect GDPR—existing users will have the feature on-by-default like new users would.
• If the anonymous IP setting is enabled, add to enqueue_gtag_js in Modules/Analytics.php.

$anonymize_ip_address = $this->get_data( 'anonymize-ip-address' );
if ( ! is_wp_error( $anonymize_ip_address ) && $anonymize_ip_address ) {
    // See https://developers.google.com/analytics/devguides/collection/gtagjs/ip-anonymization.
    $gtag_opt['anonymize_ip'] = true;
}

Changelog entry

• Anonymize IP addresses by default in Google Analytics snippet, and grant the user control to modify with a new setting.

Describe the bug
When adding Analytics for a site that already has a Analytics tracking code (UA-XXXX) the plugin correctly identifies and informs the user that Analytics tracking code already existing on that website.

Because an existing Analytics tag was found the pre-populated 'Account' and 'Property ID' should reflect that correct analytics property name. Even though it's the "Property ID' is greyed out it might be misleading for users as the references.

The notice might be also improved to state something more relevant such as "Press the Configure Analytics button to use the existing Analytics profile or remove your Analytics tracking code before refreshing this screen and selecting a new or existing account & property."

To Reproduce
Steps to reproduce the behavior:

1. Setup Analytics module using Site Kit using a website that already has Analytics tracking code

Expected behavior
The greyed out property name should match the Analytics property name found on the site. And a more description text on possible course of actions.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

When viewing the site homepage, users should see the adminbar menu. clicking this will show them details for the hompage only (eg not the entire site). Currently in my testing, I do not see the Site Kit menu on the homepage.

This only applies if the homepage already has stats available in Search Console.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Ensure admin bar menu shows as expected for single posts when on a staging or development environment mirroring real posts, and ensure the menu is shown for the correct single post.

Acceptance criteria

• For the following tests, either:
  • make sure the posts you test with have actual search console data available
  • or temporarily comment out the logic to make the admin bar menu depend on search console data
• Set up your homepage to show a list of posts.
• Go to the homepage and ensure the admin bar menu does not show up (since it for now only shows for individual posts).
• Set up your homepage to show a static page and also pick a page in the same section for your blog.
• Go to the homepage and ensure the admin bar menu shows up (since the homepage now is an actual post).
• Go to the blog page and ensure the admin bar menu shows up (since the blog page is now an actual post). It should show stats for that blog page, not for any of the posts listed.
• Ensure the More Stats links in the admin bar lead to the dashbaord detail stats for the same page in the backend.

Query by clicks, add a column with clicks data (keep impressions too) and order them by clicks.

@ThierryA @felixarntz I think we need to discuss this one a bit more but spinning up the ticket to make sure it doesn't get forgotten.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The Popularity widget table on the Site Kit dashboard shows a Clicks column, on the left side of the Impressions column.
• Keywords in the Popularity widget table are sorted by clicks, descending.

Implementation brief

• Remove Search Console datapoint search-keywords-sort-by-impressions.
• In the case for the remaining datapoints, remove everything but https://github.com/google/site-kit-wp/blob/develop/includes/Modules/Search_Console.php#L496 (no longer manually sort by impressions). This is okay to do because the other datapoints than search-keywords were accidentally changed to also be sorted by impressions and can easily be changed back to be sorted by clicks (default) without user-facing effects.
  • sc-site-analytics is only called for dashboard areas where sorting is irrelevant for how the data is displayed (data block with only totals, line chart).
  • page-analytics is only called in one place, where it's used for a data block with only totals. Actually that datapoint appears to be doing exactly the same as sc-site-analytics, so I'd suggest removing it entirely.
  • index-status is not used at all, but let's not remove it for now - we can revisit that.
• Use search-keywords-sort instead of search-keywords-sort-by-impressions in https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/search-console/dashboard/dashboard-widget-popular-keyword-table.js#L111.
• Add a "Clicks" column below https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/search-console/dashboard/dashboard-widget-popular-keyword-table.js#L66, using the existing definition from https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/search-console/dashboard/dashboard-widget-keyword-table.js#L42 (which is used on Search Console module page).
• For reference, https://developers.google.com/webmaster-tools/search-console-api-original/v3/searchanalytics/query (results are always sorted by Clicks, which cannot be adjusted).

Changelog entry

• Show Clicks in the plugin dashboard's Popularity listings and sort the table by them.

Hello,

I would like to propose to the Google Team some additions to the plugin regarding Google Analytics (there are also attached screenshots):

1. Top 10 Countries, This list shows the top countries your website visitors are from ( https://ibb.co/zsJfGZT );

2. Top 10 Referrals, This list shows the top websites that send your website traffic, known as referral traffic. ( https://ibb.co/4MNDQgb );

3. Enable reporting on Demography and Interest for Remarketing and Advertising ( https://ibb.co/bddH32d )

4. Anonymize IP Addresses ( https://ibb.co/Sw3zcSJ )

5. New vs. Returning Visitors / Device Breakdown ( https://ibb.co/VHLmMwy )

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

FILE: google-site-kit/vendor/phpseclib/phpseclib/phpseclib/Net/SFTP/Stream.php

---

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

182 | WARNING | Global with anything other than bare variables is discouraged since PHP 7.0. Found ${$host}

FILE: google-site-kit/vendor/phpseclib/phpseclib/phpseclib/bootstrap.php

---

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

10 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2

FILE: google-site-kit/vendor/phpseclib/phpseclib/phpseclib/Crypt/Base.php

---

FOUND 45 ERRORS AND 1 WARNING AFFECTING 26 LINES

792 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
792 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
825 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
825 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
828 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
828 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
833 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
833 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
842 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
842 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
852 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
852 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
855 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
855 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1132 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1132 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1160 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1160 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1165 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1165 | ERROR | Function mcrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1174 | ERROR | Function mdecrypt_generic() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1177 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1177 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1659 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1659 | ERROR | Function mcrypt_list_algorithms() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1738 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1738 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1739 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1739 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1744 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1744 | ERROR | Function mcrypt_module_close() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1851 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
1852 | ERROR | The constant "MCRYPT_MODE_CBC" is deprecated since PHP 7.1 and removed since PHP 7.2
1854 | ERROR | The constant "MCRYPT_MODE_CFB" is deprecated since PHP 7.1 and removed since PHP 7.2
1855 | ERROR | The constant "MCRYPT_MODE_NOFB" is deprecated since PHP 7.1 and removed since PHP 7.2
1856 | ERROR | The constant "MCRYPT_MODE_STREAM" is deprecated since PHP 7.1 and removed since PHP 7.2
1859 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1859 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1860 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1860 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1866 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1866 | ERROR | Function mcrypt_module_open() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
1866 | ERROR | The constant "MCRYPT_MODE_ECB" is deprecated since PHP 7.1 and removed since PHP 7.2
1871 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
1871 | ERROR | Function mcrypt_generic_init() is deprecated since PHP 7.1 and removed since PHP 7.2; Use OpenSSL instead
2610 | WARNING | Function create_function() is deprecated since PHP 7.2; Use an anonymous function instead

FILE: google-site-kit/vendor/phpseclib/phpseclib/phpseclib/Crypt/Random.php

FOUND 5 ERRORS AFFECTING 2 LINES

69 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
69 | ERROR | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead
108 | ERROR | Extension 'mcrypt' is deprecated since PHP 7.1 and removed since PHP 7.2; Use openssl (preferred) or pecl/mcrypt once available instead
108 | ERROR | Function mcrypt_create_iv() is deprecated since PHP 7.1 and removed since PHP 7.2; Use random_bytes() or OpenSSL instead
108 | ERROR | The constant "MCRYPT_DEV_URANDOM" is deprecated since PHP 7.1 and removed since PHP 7.2

FILE: google-site-kit/vendor/symfony/yaml/Parser.php

---

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

72 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2

FILE: google-site-kit/vendor/symfony/yaml/Inline.php

---

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

55 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix PHP 7+ compatibility warnings by removing unused phpseclib/phpseclib dependency.

Acceptance criteria

Describe the bug
Some errors are hardcoded to return in German language

To Reproduce
https://github.com/google/site-kit-wp/blame/9a262cd18c33995ce5ec81bc300ff055dff2a153/includes/Core/Storage/Data_Encryption.php#L123
https://github.com/google/site-kit-wp/blame/9a262cd18c33995ce5ec81bc300ff055dff2a153/includes/Core/Storage/Data_Encryption.php#L143

There may be more. I found these while referencing #7

Expected behavior
Errors and/or code should preferably be English to enhance collaboration

The free version of the WordFence plugin for WordPress sprung a false positive the day after I installed Site Kit. It said:

• This file may contain malicious executable code: wp-content/plugins/google-site-kit/vendor/phpseclib/phpseclib/phpseclib/Crypt/Base.php

I just wanted to make you aware, in case there's anything you could tweak to avoid this happening, or in case there's a way to get whitelisted by WordFence. WF is such a popular plugin, this could happen to a lot of people.

Perhaps once Site Kit is in the WP repository, this won't happen, not sure!

Describe the bug
I have 2 properties on an account. I have chosen the second property, however SiteKit Analytics insists on displaying the data for the first property.

To Reproduce
Steps to reproduce the behavior:

1. Go to Settings
2. Connect Analytics with an account you have at least 2 properties on
3. Select an account that's not the first

Expected behavior
It should be showing the accurate property

System Information (please complete the following information):

• PHP Version: 7.3
• OS: Mac OS High Sierra
• Browser Chrome 75
• Plugin Version beta 1
• Device: Desktop Mac

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Describe the bug
The current implementation to check existing tag from the js client is with iframe. And the iframe has sandboxed mode, thus it will block script execution, and thown console log error. Even it is an expected behavior, it cause confusion.

To Reproduce
Steps to reproduce the behavior:

1. Activate and Authenticate Site Kit
2. Activate Analytics Service
3. Go to Site Kit > Settings
4. See error in console log.

Expected behavior
No console log error thrown.

Screenshots

System Information (please complete the following information):

• PHP Version: 7.2.14
• OS: Mac OSX
• Browser: Opera 60
• Plugin Version: 1.0.0-beta.1 develop branch
• Device: Macbook Pro

Technical Implementation Brief
Instead of using iframe to grab the html of the frontend site.
We can dynamically fetch the frontend page.
Also use timestamp when do request, for example: https://<domain>/?tagverify=1&source=sitekit&timestamp=123456777, so we won't hit the page cache.
Store the html content in sessionStorage for future use.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Replace usage of an iframe to detect existing Analytics or AdSense tags with a fetch request.

Acceptance criteria

• On a fresh setup, set up the Analytics module. Ensure that you can choose the property and that the snippet is placed on the site after completion.
• Do the same test for AdSense.
• Disconnect both modules again (or restart with a fresh setup).
• Insert an Analytics snippet and an AdSense snippet into the site through another means (e.g. manually, or 3P plugin).
• Start Analytics module setup again. Ensure the existing tag is detected (and thus you're locked to using that).
• Do the same test for AdSense.
• Remove the custom snippets placed manually before again.
• Go to Analytics settings and click "Edit". Make sure it no longer includes references to the already existing tag.

Couldn't create project
warning
field [project_id] has issue [project_id contains invalid characters]

Describe the bug
Site Kit currently expects the admin bar to exist while in the backend, in various areas of the code. This should not be relied on as it is possible for the admin bar to not exist even in the WordPress backend (e.g. on a Site which uses the WordPress.com admin bar provided by the Jetpack plugin). This for example causes the JavaScript error reported in #11.

Let's make sure that, wherever in the plugin we access a node that is part of the admin bar, we check for whether that node actually exists before executing logic on it.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix JavaScript error when admin bar is missing and add partial support for WordPress.com toolbar.

Acceptance criteria

Describe the bug
I'm using a WordPress network installation and deployed the Google SiteKit plugin in a single site. OAuth app was configured for both URLs (wordpress.network.com/site and blog.site.com) and the first step of authentication and consent is almost complete but the final postback just presents this message: "Unable to receive access token because of an empty authorization code."

To Reproduce
Steps to reproduce the behaviour (in my case):

1. Go to Dashboard
2. Click on Left Menu "Site Kit"
3. Click on Left Menu "Sign in with Google"
4. Select user, ok
5. Consent permissions
6. Allow

Expected behavior
Would like to see the Site Kit Dashboard

System Information (please complete the following information):

• PHP Version: 7.2.7
• WordPress: 5.2.2 - Network Install
• OS: Windows Server 2016
• Browser chrome
• Plugin Version 1.0.0-beta.1
• Device: Windows 10

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Happening on Step 2, after allowing the API and signed in, it's throwing this on the dashboard:

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Adding Events & Conversations to Single Page Stats
The single page stats are very useful.
A nice addition would be to also see events and conversions (which have previously been defined and set up using other plugins or the Google tag manager).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Feature Description

Introduce a filter for analytics parameters on the FE.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• There is already a googlesitekit_gtag_opt filter for the regular Analytics configuration options in https://github.com/google/site-kit-wp/blob/develop/includes/Modules/Analytics.php#L276. That filter is sufficient for this part, however its doc-block should clarify that it filters configuration options for the Analytics snippet. Not as many people understand what "gtag" is right away (at the same time, the doc-block should continue to mention that this is for gtag, to differentiate it from other Analytics snippet types people might be familiar with).
• To cover AMP, an additional googlesitekit_amp_gtag_opt filter should be introduced, for the object that is passed to amp-analytics as JSON in the Analytics module. The docs should have a @see annotation pointing to https://developers.google.com/gtagjs/devguide/amp.
• A key requirement for the AMP filter is that the tracking ID itself must not be changed (for the non-AMP filter, the tracking ID isn't part of the options anyway). In order to ensure that, logic should be added after running the filter that resets the tracking ID value to the original one (in case someone tried to change it). All other properties should be freely customizable.

Implementation brief

• Update doc-block for googlesitekit_gtag_opt filter clarifying that it filters configuration options for the Analytics snippet.
  Keep mention that is for gtag.
  

  site-kit-wp/includes/Modules/Analytics.php

  Line 268 in 4c69165

  * Filters the gtag config options.

• Add filter googlesitekit_amp_gtag_opt to make it available for developers to modify the $config options

  site-kit-wp/includes/Modules/Analytics.php

  Line 317 in 4c69165

  $config = array(

• Add @see annotation in the doc-block of the filter pointing to https://developers.google.com/gtagjs/devguide/amp

• After running the filter ensure $config['vars']['gtag_id'] exists and set it to the original $tracking_id

Changelog entry

• Allow filtering the Google Analytics gtag configuration options for both AMP and non-AMP context.

We plan to expand the plugin’s capabilities and integrations in the future; we’d love to get your feedback on which products and features we should prioritize.

Would be nice if Site Kit could add a "Sign in with Google" button option to Wordpress' login screen.

Currently this freemium plugin (No affiliation) adds this functionality.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Bug Description

The table below doesn't make sense on the single page detail page since we have already drilled down. We can remove it here.

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix incorrect label for Top Pages table when viewing insights for a single post.

Acceptance criteria

• Ensure the title for the Top Pages table on the overall dashboard refers to the "site".
• Ensure the title for the Top Pages table on a single post dashboard view refers to the "page".

We plan to expand the plugin’s capabilities and integrations in the future; we’d love to get your feedback on which products and features we should prioritize.

Would like to see Google My Business' dashboard insights available within Site Kit.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Describe the bug
PHP warnings for undefined constants LOGGED_IN_KEY and LOGGED_IN_SALT.

To Reproduce
Steps to reproduce the behavior:

1. Install Site Kit plugin
2. Enable PHP error logging
3. Activate Site Kit plugin in WordPress
4. Many PHP warning notices for undefined constants

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 118

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 119

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 138

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 139

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 118

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 119

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 138

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 139

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 118

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 119

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 138

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 139

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 118

Warning: Use of undefined constant LOGGED_IN_KEY - assumed 'LOGGED_IN_KEY' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 119

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 138

Warning: Use of undefined constant LOGGED_IN_SALT - assumed 'LOGGED_IN_SALT' (this will throw an Error in a future version of PHP) in example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php on line 139

Warning: Cannot modify header information - headers already sent by (output started at example.com/wp-content/plugins/google-site-kit/includes/Core/Storage/Data_Encryption.php:138) in example.com/wp-admin/includes/misc.php on line 1196

More information and proposed fix.

System Information (please complete the following information):

• PHP Version: 7.2.14
• OS: macOS (Mamp Pro)
• Browser Safari 12.1.1/macOS
• Plugin Version: 1.0.0.beta.1
• Device: MacBook Pro 2018

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Check if LOGGED_IN_KEY and LOGGED_IN_SALT are defined before using it, to account for some environments such as local ones.

Acceptance criteria

Bug Description

• When selecting 'Set up a new container' it doesn't actually create a new container but selects the first item in the list. I get an error for "User does not have sufficient permissions for this account", similar to Analytics' error message

• I also got the following error message after saving which may have been specific to me, but thought I'd log it here. "Error: Quota exceeded for quota group 'default' and limit USER-100s of service tagmanager.googleapis.com for consumer project_number:495584684379."

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Create a Tag Manager container if the user does not have one yet, normalize the container name, and display an error if container creation fails.

Acceptance criteria

• As a first step, do the check for whether the user's accounts has necessary permissions to create a container.
• If the account doesn't have permissions, display an informational message similar to what we do for Analytics in that case.
• If the account does have permission to create a container, actually create a container instead of selecting the first item on the list.
• If the same container name already exist, select that container and give a notice message back to the user.

Implementation Brief

• Normalize the non-ASCII characters when setting the container name: https://github.com/google/site-kit-wp/blob/develop/includes/Modules/TagManager.php#L403
• Check if the account has container(s):
  • If not, try to create a container from the server side, if succeed then finish setup
  • If account has container(s), show dropdown
• When the same container name exist, TagManager service API will return error response. On Settings page, this error response is not displayed due to the way of the component is setup.
  The Confirm button is located outside the setup component and triggered with wp.hooks:
  https://github.com/google/site-kit-wp/blob/develop/assets/js/modules/tagmanager/setup.js#L69-L80

When the TagManagerSetup component received error response, it should throws error, so it would catch later by ModulePromise in this line:

Then when re-create the setup component, set error message from props, so the setup component can show the error response.

At the moment I'm only able to see the data connected to my own google account. I can't share data between other WordPress accounts.

It would be great to be able to share data with other WordPress accounts. I imagine having a list of all WordPress Users where I could select some Users that are able to see what I am seeing. Maybe they could then choose my Google account on the dropdown on the upper right corner.

This way it would also be possible to reveal the data to Admins that don't have a google account or if you have employees with a WordPress login (company-email) which is not a google account and you don't want to give access to the google services over their private google accounts.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Hello,
you should add the possibility to anonymize the IP address between the settings (Google Analytics) of the plugin, other plugins that integrate Analytics grant this possibility.

Let's revive #2 to fix a small issue where esc_url() should be used for strings that appear in a src attribute.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• URL attribute values are escaped using the appropriate WP API function.

Implementation Brief

URL attribute values are fully escaped using esc_url in the following methods:

• \Google\Site_Kit\Modules\TagManager::print_gtm_no_js
• \Google\Site_Kit\Modules\TagManager::print_amp_gtm
• \Google\Site_Kit\Core\Util\Tracking::print_gtag_script

Changelog entry

• Update URL attributes to escape the full URLs.

Could basic event tracking be set up as an additional option in the Analytics section? It's a common need, but one that can be technically tricky for users.

Events would be: form submissions, mailto and tel clicks, doc downloads and outbound links.

Currently I would need to install a separate plugin to do this, For example the Exact Metrics plugin has an option to track these things. But I think this could be incorporated into Site Kit and would be a good fit.

Alternatively I could implement Tag Manager which is probably overkill and too complex for most WordPress users to set up.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Is your feature request related to a problem? Please describe.
Please publish the plugin in packagist so that it is reachable with a standard composer based WordPress installation.

Describe the solution you'd like
Packagist publication

Describe alternatives you've considered
Manual git config

Additional context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Describe the bug
When sending reporting data, the plugin currently sends the "site url" sometimes with and sometimes without the trailing slash, resulting in duplicated tracking entries.

To Reproduce
Steps to reproduce the behavior:

1. Set up the plugin on a new domain.
2. Check the domain sent for tracking events.

Expected behavior
The domain used for tracking should be consistent, never including a trailing slash.

Screenshots
If applicable, add screenshots to help explain your problem.

System Information (please complete the following information):

• PHP Version:
• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Plugin Version [e.g. 22]
• Device: [e.g. iPhone6]

Additional context

• Please add any additional information about the bug.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Ensure domain sent for reporting is consistent by trimming any trailing slashes.

Acceptance criteria

Describe the bug
Inconsistency between Analytics components error message when Analytics is not configured yet.

To Reproduce
Steps to reproduce the behavior:

1. Activate and Authenticate Site Kit
2. When connect Analytics service, stop before save anything.
3. Go to Site Kit dashboard.
4. See inconsistency between Analytics component error message.

Expected behavior
Show consistency error message, and if can add a link for user to continue to setup Analytics.

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Standardize CTA messaging for when setup for a module has not been completed yet.

Acceptance criteria

after uploading plugin receiving following error The site is experiencing technical difficulties.

Describe the bug
I click sign in with Google and authorize the site. After giving all the permissions, I am redirected to the site homepage. When get back to the Site Kit dashboard, I see the sign in option again.

Expected behavior
The authentication process should have completed and the step should have moved to Verify URL.

System Information (please complete the following information):

• PHP Version: 7.3.6
• OS: OSX Mojave
• Browser: Chrome 75.0.3770.100 (Official Build) (64-bit)
• Plugin Version: 1.0.0-beta.1
• Device: MacBook Air

Additional context
I have checked for theme and plugin conflicts. But the issue is still there.
I have SSL enabled on my site from Let's Encrypt free SSL.

Describe the bug
I attempted to install the plugin on a shared hosting account with nodejs version 6. I know it is pretty old but cannot get a newer version on this specific account. The npm install and run build failed. The Site Kit in the WP Dashboard was added but displayed a blank page.

To Reproduce
Steps to reproduce the behavior:

1. Try to install the plugin on a server with nodejs version 6.

Expected behavior
I expected the Site Kit to work in the wp-admin area.

System Information (please complete the following information):

• PHP Version: latest 7.2
• OS: CentOS
• Browser: Chrome
• Plugin Version: Latest cloned from GitHub
• Device: MacBook Pro

Additional context

• At this point I want to understand better what version of nodejs and npm is required to install the plugin so that it works.

Describe the bug
Webpack throw error during build process because of languages/translation.pot not found.

To Reproduce
Steps to reproduce the behavior:

1. Download the repo
2. Run npm install && npm run build
3. See error

Expected behavior
Webpack build should success.

System Information (please complete the following information):

• PHP Version: 7.1
• OS: Mac OSX
• Browser: Opera
• Plugin Version: 1.0.0-beta.1

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Remove translation file generator from build process and the @wordpress/babel-plugin-makepot package.

Acceptance criteria

Describe the bug
Tested on site hosted within subdomain and subpath (demo.***.io/sample).
Newly setup site, Site Kit just added, API key is correct and no restrictions, copied as per setup process. PageSpeed services/module is appearing as "Connected" under 'connected services' tab in Site Kit Admin.

To Reproduce
Install Site Kit on subdomain & subpath.

pagespeed-insights::site-pagespeed-desktop::last-28-days::d41d8cd98f00b204e9800998ecf8427e: {errors: {400: ["Bad Request"]}, error_data: {400: {status: 500, reason: "keyInvalid"}}}
error_data: {400: {status: 500, reason: "keyInvalid"}}
errors: {400: ["Bad Request"]}
pagespeed-insights::site-pagespeed-mobile::last-28-days::d41d8cd98f00b204e9800998ecf8427e: {errors: {400: ["Bad Request"]}, error_data: {400: {status: 500, reason: "keyInvalid"}}}
error_data: {400: {status: 500, reason: "keyInvalid"}}
errors: {400: ["Bad Request"]}

Response:
{"pagespeed-insights::site-pagespeed-mobile::last-28-days::d41d8cd98f00b204e9800998ecf8427e":{"errors":{"400":["Bad Request"]},"error_data":{"400":{"status":500,"reason":"keyInvalid"}}},"pagespeed-insights::site-pagespeed-desktop::last-28-days::d41d8cd98f00b204e9800998ecf8427e":{"errors":{"400":["Bad Request"]},"error_data":{"400":{"status":500,"reason":"keyInvalid"}}}}

System Information (please complete the following information):
WordPress Version: 5.2.2
Web Host OS: Linux
Site Kit Plugin version: 1.0.0-beta.1
Browser: Chrome
Operating System: Macos 10.13.6
PHP Version: 7.2

Can't create the OAUTH Credentials.. After clicking on the "get Credentials" Button i got the Error:
Couldn't create project - warning field [project_id] has issue [project_id contains invalid characters]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

If you have an existing Analytics property that matches your site URL, except for the scheme (HTTP vs HTTPS), it currently isn't detected as a match, although it should. The same should apply to AdSense, and any other module where such detection takes place.

The permute_site_urls() method used by Search Console is the perfect foundation to achieve that. Let's make sure the other modules use it as well, to fix this bug.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix URL matches for http and https variations in Analytics and AdSense modules.

Acceptance criteria

Describe the bug
The composer.json of Site Kit requires johnpbloch/wordpress-core. When installing WordPress core from another source this causes an unwanted copy of WordPress core to be downloaded.

Specifically, I use pantheon-systems/wordpress-composer as the source for WordPress core and install it to the path web/wp.

Because Site Kit requires johnpbloch/wordpress-core another copy of WordPress core, which I do not want as a dependency, is installed to the wordpress directory.

I cannot find a way to not have the johnpbloch/wordpress-core version of WordPress core downloaded.

To Reproduce
Steps to reproduce the behavior:

1. Clone pantheon-systems/example-wordpress-composer
2. Add an entry for the Google Site Kit plugin in the repositories section of composer.json

   {
     "type": "vcs",
     "url": "https://github.com/pantheon-systems/wordpress-composer"
   }

3. Add an entry for the Google Site Kit plugin in the require section of composer.json

   "google/google-site-kit": "1.0.0-beta.1"

4. Run composer update
5. Verify that the Pantheon copy of WordPress core is installed to web/wp as wanted
6. See that an unwanted copy of WordPress core is downloaded to the wordpress directory

Expected behavior
Site Kit, a WordPress plugin, does not force a specific version of WordPress core on Composer based projects that require the plugin as a dependency.

Screenshots

System Information (please complete the following information):

• PHP Version: 7.3
• OS: macOS Mojave 10.14.5
• Browser: N/A
• Plugin Version: beta1
• Device: Macbook Pro

Additional context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Move johnpbloch/wordpress-core dependency to require-dev in composer.json.

Acceptance criteria

I am getting a blank screen when trying to access the Site Kit admin screen.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• N/A

Acceptance criteria

Once the plugin is installed and I go to set up the client configuration it has it tells me that it has issues accessing data and to Reauthenticate my google account as seen below -

Once I click that it crashes and sends me an email containing this information with error:

An error of type E_ERROR was caused in line 651 of the file /www/shesocial_856/public/wp-content/plugins/google-site-kit/vendor/google/auth/src/OAuth2.php. Error message: Uncaught InvalidArgumentException: missing the required redirect URI in /www/shesocial_856/public/wp-content/plugins/google-site-kit/vendor/google/auth/src/OAuth2.php:651
Stack trace:
#0 /www/shesocial_856/public/wp-content/plugins/google-site-kit/vendor/google/apiclient/src/Google/Client.php(340): Google\Auth\OAuth2->buildFullAuthorizationUri(Array)
#1 /www/shesocial_856/public/wp-content/plugins/google-site-kit/includes/Core/Authentication/Clients/OAuth_Client.php(444): Google_Client->createAuthUrl()
#2 /www/shesocial_856/public/wp-content/plugins/google-site-kit/includes/Core/Authentication/Authentication.php(502): Google\Site_Kit\Core\Authentication\Clients\OAuth_Client->get_authentication_url('https://shesoci...')
#3 /www/shesocial_856/public/wp-content/plugins/google-site-kit/includes/Core/Authentication/Authentication.php(189): Google\Site_Kit\Core\Authentication\Authentication->handle_oauth()
#4 /www/shesocial_856/public/wp-includes/class-wp-hook.php(286): Google\Site_Kit\Core\Authentication\Authentic

Describe the bug
Can't setup Analytics on my site: https://www.saibatudomt.com.br/

Blocked script execution in 'https://www.saibatudomt.com.br/?tagverify=1' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.

System Information (please complete the following information):

• Plugin Version 1.0.0-beta.1

Describe the bug
After successfully connecting an Analytics account (using the same Google account OAuth which to verify the setup) an "Issue accessing data" notice appears.

While Analytics reporting in the dashboard is fine there the notice remains and trying to re authenticate your account via the button in the notice doesn't solve the issue, the notice reappears.

To Reproduce
Steps to reproduce the behavior:

1. Active Site Kit
2. Settings > Connect more services > Analytics
3. Complete setup procedure

Expected behavior
Notice should not appear

System information:

• PHP Version: 7.2
• OS: Mac
• Browser : Chrome
• Plugin Version: 1.0.0-beta.1
• Host OS: Linux
• Additional Plugins: TagDiv Composer

Additional context
Another report of same issue from this issue: #1

Site Kit data module check:
https://github.com/google/site-kit-wp/blob/develop/assets/js/components/data.js#L275-L280
insufficientPermission is because of oauth scopes, which happen in most of the cases.
In this case the insufficientPermission is because user doesn't have access to the Analytics Goals.

Preliminary work here:
https://github.com/google/site-kit-wp/compare/fix/insufficient-permission?expand=1

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

• For every user who has successfully set up GA and metrics appear in the main plugin dashboard, no error notices should appear.
• For users that do not have access to Goals, the goals datablock will show a CTA to request access.

Implementation Brief

• Remove the insufficientPermission error check from the data module. insufficient scope check already in place elsewhere.

• Handle insufficientPermission error specifically in AnalyticsDashboardWidgetTopLevel component
  

  site-kit-wp/assets/js/modules/analytics/dashboard/dashboard-widget-top-level.js

  Line 362 in 9a262cd

  getAnalyticsErrorMessageFromData

  - when the goals data point returns insufficientPermission show a CTA that the user cannot access Goals.

I currently have the plugin on https://poisar.com. The issue seems that after the integration, the PageSpeed Insights API has some sort of data error. I properly enabled the PageSpeed API and only have restrictions as it pertains to utilizing poisar.com and .poisar.com/ via the API. Please reference the following images.

Feature Description

Introduce settings to control Analytics parameters.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Describe the bug
The flow for setting the Analytics module fails to complete with a blank screen.
To Reproduce
Steps to reproduce the behavior:

1. Activate Analytics module

Expected behavior
Displaying analytics properties selection

System Information (please complete the following information):

• Browser: Chrome
• Plugin Version: beta1

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix analytics setup flow empty render for accounts with only shared properties or views.

Acceptance criteria

Describe the bug
Site Kit stats don't load in Admin Bar. Instead, we only show a progress bar.

To Reproduce
Steps to reproduce the behavior:

1. Go to a live page of https://www.getbeans.io/ while logged in to WordPress as admin
2. Click on Site Kit icon in admin bar
3. Site Kit element loads, but only progress bar is shown, no stats.

Expected behavior
Stats should load in the Admin Bar.

Screenshots

System Information (please complete the following information):

• OS: macOS Mojave 10.14.5
• Browser: Chrome Version 75.0.3770.90
• Plugin Version: Version 1.0.0-beta.1
• Device: Macbook Air

Additional context
Console error from Chrome devtools:
Uncaught TypeError: Cannot read property 'mapValues' of undefined
at Module.326 (7fe2108.js:453)
at r (7fe2108.js:453)
at wp.keycodes.1 (7fe2108.js:453)
at 7fe2108.js:453

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

• All elements in the Admin bar should load when the user opens a page of their site while logged in.

Describe the bug
When trying to generate oauth credentials I get the following error:

Couldn't create brand
Request contains an invalid argument.

To Reproduce
Steps to reproduce the behavior:

1. In WordPress with SiteKit plugin installed Go to wp-admin/admin.php?page=googlesitekit-splash
2. Click on link "developers.google.com/web/sitekit"
3. Click "GET OAUTH CREDENTIALS"
4. Proceed until error appears

Expected behavior
Credentials to be generated and shown

Screenshots

System Information (please complete the following information):

• PHP Version: 7.2.19
• Browser: Chrome
• Plugin Version: 1.0.0-beta.1
• Device: MacBook

Additional context

• The same error occurs whether I use the prefilled data from the link in the WordPress settings page, or go directly to https://developers.google.com/web/site-kit/ and enter the info from scratch

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

Acceptance criteria

Describe the bug
Enabling site kit plugin breaks the AMP version of the site. It just showing 49 years ago, article tags and categories.

To Reproduce
Steps to reproduce the behavior:

1. Install Site Kit plugin and configure it
2. Install AMP plugin By AMP Project Contributors
3. Try accessing AMP page of the site
4. See error

Screenshot

System Information (please complete the following information):

• PHP Version: 7.2.19
• Browser: chrome
• Plugin Version 1.0.0-beta.1

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Fix PHP notices being thrown on AMP reader mode when Analytics or Tag Manager snippet is not inserted.

Acceptance criteria

• Activate the AMP plugin and configure it to use Reader mode in its settings screen.
• Configure Site Kit's Analytics module. In Site Kit > Settings, ensure the snippet is not inserted.
• Open a single post in the frontend and click on "AMP" in the admin bar to view its AMP version.
• Verify that no PHP notices are being thrown and the page renders correctly.
• Start setup of Site Kit's Tag Manager module, but then immediately bail out (e.g. by going to another WordPress page), so that the setup is flagged as incomplete.
• Open a single post in the frontend and click on "AMP" in the admin bar to view its AMP version.
• Verify that no PHP notices are being thrown and the page renders correctly.

The current Travis-CI test matrix has a few issues:

• The oldest supported WordPress version (4.7) is not tested with.
• We run most tests with WordPress master which might easily fail just because WordPress's nightly build itself has a problem.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Changelog entry

• Enhance Travis-CI build matrix to test against oldest and newest supported WordPress versions.

Acceptance criteria