Git Product home page Git Product logo

Comments (11)

rukai avatar rukai commented on April 29, 2024 2

The problem is with cmake_rs I will file an issue upstream.
In the mean time a workaround is to add cmake = "=0.1.35" to your Cargo.toml

from shaderc-rs.

aszecsei avatar aszecsei commented on April 29, 2024

It looks like this is due to Ninja being used as the build system; not sure if this is related #41 or not, but at least it's a workaround for now. Is it possible to get a feature to disable Ninja support so I can re-add it to my path?

from shaderc-rs.

JoshuaBatty avatar JoshuaBatty commented on April 29, 2024

I'm also getting the same error on MacOS 10.14.... have you had any success getting this to build yet?

from shaderc-rs.

aszecsei avatar aszecsei commented on April 29, 2024

Yes, I removed ninja from my path and it worked.

from shaderc-rs.

hodasemi avatar hodasemi commented on April 29, 2024

I can confirm that I get the same error on Linux, removing ninja also worked here.

from shaderc-rs.

ntgraff avatar ntgraff commented on April 29, 2024

I am getting the same error on Linux, but only when not compiling in a git repository. The same exact code compiles fine while inside of a git repository.

Edit: Nvm, see below

from shaderc-rs.

rukai avatar rukai commented on April 29, 2024

@ntgraff Oooh Thats it, I just hit this and didn't understand why i wasn't getting it in other crates.
I do have ninja installed as well.

Edit: Wait no, thats incorrect sorry. :(
I was still running into this issue even when I initiated git and made a single commit for my broken project.

However I ran cargo update on my working project which updated these crates:

    Updating crates.io index
    Updating approx v0.3.1 -> v0.3.2
    Updating cc v1.0.30 -> v1.0.32
    Updating cmake v0.1.35 -> v0.1.36
    Updating objc v0.2.5 -> v0.2.6
    Updating ordered-float v1.0.1 -> v1.0.2

After doing so I got this issue on that project.

from shaderc-rs.

antiagainst avatar antiagainst commented on April 29, 2024

Thanks for the investigation and solution! :) And sorry about the Ninja hassle. I'll add a cargo feature to disable using Ninja.

from shaderc-rs.

cedric-h avatar cedric-h commented on April 29, 2024

I'm... still getting this. How am I to go without ninja, if I need to compile for msvc and msvc requires it?

from shaderc-rs.

antiagainst avatar antiagainst commented on April 29, 2024

Hey @DefecateRainbows, sorry to hear about that. Are you using the newest version and still seeing this issue?

Right now the build options for shaderc-sys is already quite complicated. I'm reluctant to make it even more so by throwing in another option / feature to work around MSBuild bugs. IMHO, using ninja is just ... better. Even Visual Studio itself now ships with Ninja (in c/Program Files (x86)/Microsoft Visual Studio/2017/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/Ninja/). So is there a compelling reason preventing you from using it or downloading ninja if you don't have VS installed? Please let me know. :)

from shaderc-rs.

ElhamAryanpur avatar ElhamAryanpur commented on April 29, 2024

I had same issue but a workaround I found after reading and trying around was:

Ninja is needed for windows platform but optional elsewhere, so what I did was get Ninja binary and make a folder on root and add it there. Then make a build.rs and add that folder to path. This worked like a charm for me!

Hope it helps for people who are stuck!

from shaderc-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.