Comments (5)
fwiw, #130 fixes docs.rs builds for x86_64-pc-windows-msvc
. Versions prior simply could not build docs for this target and others at all if it depended on shaderc, this is clear if you look at docs for shaderc before 0.8.2. This is understandably an issue for libraries that are Windows-focused: providing only Linux docs means my users won't be able to see docs regarding Direct3D integration.
from shaderc-rs.
Oops sorry about it! I don't know what's the best way to handle this; maybe add another environment variable like SHADERC_DOC_BUILD_FORCE_LINK
and use that in vulkano-shaders or a feature similar to that?
from shaderc-rs.
It's an understandable oversight.
I hope no one takes this the wrong way, as I don't mean to offend, but to me #130 seems like either a solution to a problem that didn't exist in the first place or the wrong solution. So my solution would be to revert #130 and solve whatever issue @chyyran was actually having. Maybe I'm missing something, and some change before #130 broke cross-compilation on docs.rs or something, however if you look at the reverse dependencies of shaderc you will see that the crates have been building just fine (including cross-compilation) before. Usually the first place to look when there's a docs.rs build failure is the package metadata, so maybe removing the package.metadata.docs.rs.targets
field from @chyyran's crate will help. Or maybe @chyyran has some insight as to why their crate fails to build unlike all the others.
In any case, I maintain that penalizing all the other crates is insanity. Worst case scenario would be to simply not cross-compile on docs.rs.
from shaderc-rs.
After further inspection it appears that cross-compilation hasn't worked for any crate, exept ones that use shaderc only at build time or as an optional dependency, so I was wrong on that. Makes sense. I wish I knew how to solve this without resorting to unclean solutions. Would it even be possible to cross-compile shaderc?
from shaderc-rs.
Makes sense, I made a patchwork PR trying to make it work in build scripts and proc-macros.
from shaderc-rs.
Related Issues (20)
- Updating shaderc version HOT 3
- Linking error when building with target-feature=+crt-static HOT 2
- Unable to build on Ubuntu 20.04 LTS - build wants "python" by name, but which one? HOT 3
- Can't find `/usr/lib/libshaderc_shared.so` HOT 1
- Build fails on Windows with Windows store Python HOT 7
- Can Compiler be Send, even Sync? HOT 1
- cannot find native shaderc library on system but Vulkan-SDK is installed
- Cannot find native shaderc library on system HOT 5
- Requesting a patch release 0.8.2 HOT 1
- [Possible Regression] Link failure on `1.67-x86_64-pc-windows-msvc` HOT 1
- shader_stage pragma for task and mesh not available
- Can't build a lib for Windows with MT_StaticRelease
- Failing to build on mac m1
- dylib not found when running without "cargo run" on macOS Sonoma
- Provide a feature to prefer static linking
- Run in CI/GitHub Actions HOT 1
- mingw-w64-x86_64-ninja compiler errors for MSVC rust cargo build
- Extensions? HOT 1
- error: linking with `link.exe` failed: exit code: 1120 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shaderc-rs.