Git Product home page Git Product logo

Comments (6)

antiagainst avatar antiagainst commented on April 28, 2024 1

Yes, agreed. I also noticed this issue on buildbot recently and had a temporary solution (3d6fa5c). Looking for better ways now.

The long path is because both the default Rust target/ directory organization (attaching the super long target\x86_64-pc-windows-msvc\debug\build\shaderc-ceea3062217d891f\out\build component to the path if you build towards x86_64-pc-windows-msvc) and the target names in SPIRV-Tools (spirv-tools-spv-amd-shader-explicit-vertex-parameter). Arguably the first part carries more weight.

Funnily we are in the year of 2019 now, yet still suffer from some limitation from DOS time. MSBuild should really be modernized: dotnet/msbuild#53.

from shaderc-rs.

antiagainst avatar antiagainst commented on April 28, 2024

As a temporary workaround, you can use cargo --target-dir. See .appveyor.yml.

from shaderc-rs.

antiagainst avatar antiagainst commented on April 28, 2024

I've merged #38, which will detect whether Ninja exists in PATH and use it if true. It's pulling in another dependency (which is likely already installed on C++ dev machines), but Ninja is generally faster than MSBuild and does not suffer from MAX_PATH issue.

To make MSBuild work means to trim down the path. As discussed in #33 (comment), neither the default Rust target directory organization nor the SPIRV-Tools target name is easy to trim down for that purpose. And both of them can change again in the future.

from shaderc-rs.

Lokathor avatar Lokathor commented on April 28, 2024

The existence of this workaround should also be explicitly documented in the README.md

from shaderc-rs.

antiagainst avatar antiagainst commented on April 28, 2024

@Lokathor, it's already documented in README with a4f1bcc.

from shaderc-rs.

Lokathor avatar Lokathor commented on April 28, 2024

oh! so it is, foolish me

from shaderc-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.