Comments (2)
The NullPointerException
was not intended, it's a bug that was fixed in v0.9.3, so you can update to at least avoid this exception. (If you're using the library via Open Bidder, that will have a release later this week, catching up with the current OpenRTB libs.) I agree this representation of enums doesn't support the extended values allowed by the spec, but it's a tradeoff we've made for a more convenient, strong-typed API. (And frankly this is a bad feature of the spec IMO, so we don't plan to ever use it in AdX' upcoming OpenRTB callout support; but that's a separate discussion.)
However there was always a plan to support extended values via Protobuf's unknown field feature (which makes reading/writing the extended values less convenient, but that's OK for a corner case -- you are the first user ever who reports this limitation as a problem, confirming my impression that actual usage of extended values is uncommon). But it's not a hard change and now there's demand for it, so maybe a good time to work on that. Another solution is forking the proto from this library and adding new values to the enum, this is a good workaround with the latest lib which will just ignore unknown values so you only need to add the ext values you care to process.
from openrtb.
Ah, the fix you provided in 0.9.3 works perfectly enough for me! Thank you!
I had a transitive dependency that was blocking my attempt at using the latest build (our project is on Maven 2 still). Knowing there was a fix in 0.9.3 helped me track it down, and 0.9.8 is working for me. I agree; I think in practice codes like these are remnants of system built prior to the spec formalization and it's always been enough for us to discard them or refer people to the ext
fields. I agree that the strongly typed API in terms of enums is much more robust. This library has been extremely valuable to us; thanks again.
from openrtb.
Related Issues (20)
- Native Data Asset Type >= 500 throws error during deserialization. HOT 1
- When enum name is stripped and label is PascalCased (Iab11), this value label conflicts with IAB1_1 HOT 7
- Extension Json Serialization Documentation Lacking HOT 2
- Version Specific BidRequest Writers HOT 4
- build DSP
- Wrong default value for deal auction type. HOT 3
- Handling 500+ DataAssetType Values HOT 7
- Fix miniumum JDK version in README.md HOT 1
- valid adm content and dynamic banners.
- Cannot find VideoBidResponseProtocol when running example HOT 1
- Error in Android 6.0.1
- Suppot of adm_native field in Bid Response HOT 2
- Missing Field Values for native bid request
- Failed to generate Golang source file for openrtb.proto using proto3 HOT 1
- Cannot import specific class in Eclipse HOT 4
- OpenRTB integer fields defined as boolean in openrtb.proto HOT 2
- How to add a missing field from the OpenRTB spec? HOT 1
- protoc warnings HOT 1
- Unable to use extensions 'ext'
- How to create BidResponse and send it in JSON format HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb.