Git Product home page Git Product logo

Comments (2)

opinali avatar opinali commented on May 8, 2024

Hi Michael -- Thanks for the report and the proposed fix, but we can't have this change in the library. The field adm_native is not part of the JSON specification, and this library tries to be strict with that, the goal is supporting extensions only via the specified mechanism of ext.* nodes. The support for embedded native object inside adm is a big exception, and we only do that because it's really critical, since the doubly-encoded JSON is both very inefficient and very unreadable. In the Protobuf wire format (itself a big extension) we use an alternate name adm_native because Protobuf is statically typed so it's not possible to put either a string or a child object in the same field.

However, the library doesn't support non-standard extensions just because some platform needs it (not even AdX; our own many, many custom fields are all mapped to ext.* fields). So if BidSwitch is doing this... ideally they should fix it, they could just use the regular field name adm with the nested native object inside. Or you can fork the library to support this BidSwitch-specific field.

from openrtb.

m1ck43l avatar m1ck43l commented on May 8, 2024

Hi Osvaldo
Thanks for your answer, I wasn't sure either if this was intended or not, so thanks for confirming!

from openrtb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.