Comments (4)
I agree this would be a nice improvement... normally, the read method should return null
for empty string, because an empty string is not a valid representation of any JSON object (an "empty" JSON object must contain at least {}
). But it's nasty to make the reader methods @Nullable
only for this special case. I think we can just return BidRequest.getDefaultInstance()
, which also doesn't require special casing in the caller. (The default instance is a fixed object, so you can detect if that was the returned object if you care.)
from openrtb.
an empty string is not a valida representation of any JSON object
Sure, that is why we definitely shouldn't return BidRequest with default content here
But it's nasty to make the reader methods @nullable only for this special case.
I'm not sure. Reader return "nothing" only if there is "nothing" in input and only in this case. So, this case is enough for Nullable from my perspective.
I don't like "defaultInstance" solution, because it's
- looks like a hack and magic object
- "{}" is default object ideologically, so we need getEmptyInstance and it's definitely looks like a hack because empty object is null
Accuracy to Nullable - this is why I suggest to make it as feature that user can enable. In default behavior we never return null and throw and exception (but maybe rework to throw some specific like EmptyInputException), but if user explicitly enable parsing empty input as null - we will return null.
from openrtb.
Some good points... returning the default object is clean in the theory because the Protobuf library documents that this thing is a singleton; still, I agree it's not a popular and obvious API design.
Now, an empty string is not a valid JSON input, so the exception you get today is the perfect behavior for strict parsing. Unfortunately there's no good way to detect the cause of Jackson's exceptions, other than matching the message strings, otherwise I would dismiss this as WAI. We already have a "strict" option in the API, so that's a perfect candidate for the desired feature: do setStrict(false)
, then the read methods will mask this special case and return null
. I'm still not friendly to the idea of making the return types @Nullable
for the sake of a corner case (if you have some exchange/platform sending you empty-string requests or responses they are doing it wrong...), but I suppose it's not a big sin to return null without declaring @Nullable
if the user has set a strict=false option; that opens the Pandora box of "I know what I'm doing" so it looks like a good tradeoff.
from openrtb.
(0.9.6 improved this; closing bug.)
from openrtb.
Related Issues (20)
- Native Data Asset Type >= 500 throws error during deserialization. HOT 1
- When enum name is stripped and label is PascalCased (Iab11), this value label conflicts with IAB1_1 HOT 7
- Extension Json Serialization Documentation Lacking HOT 2
- Version Specific BidRequest Writers HOT 4
- build DSP
- Wrong default value for deal auction type. HOT 3
- Handling 500+ DataAssetType Values HOT 7
- Fix miniumum JDK version in README.md HOT 1
- valid adm content and dynamic banners.
- Cannot find VideoBidResponseProtocol when running example HOT 1
- Error in Android 6.0.1
- Suppot of adm_native field in Bid Response HOT 2
- Missing Field Values for native bid request
- Failed to generate Golang source file for openrtb.proto using proto3 HOT 1
- Cannot import specific class in Eclipse HOT 4
- OpenRTB integer fields defined as boolean in openrtb.proto HOT 2
- How to add a missing field from the OpenRTB spec? HOT 1
- protoc warnings HOT 1
- Unable to use extensions 'ext'
- How to create BidResponse and send it in JSON format HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openrtb.