Git Product home page Git Product logo

Comments (4)

opinali avatar opinali commented on May 8, 2024

Hum, that's painful... I was hoping that nobody would actually have messages with null values, even if they are valid in JSON (OpenRTB implementations are supposed to avoid redundancies like 'keywords: null' because it's good to make messages shorter)... it seems that was too optimistic.

I think the only good solution here will be to change the reader so it detects VALUE_NULL tokens and skips them (option 2). Investigating this now.

from openrtb.

opinali avatar opinali commented on May 8, 2024

Ok, I have implemented support for nulls, and also used the opportunity to make another pending refactoring that will make easier for people to customize the serialization of individual fields if necessary (see Issue 10). Can you check this at the fork https://github.com/opinali/openrtb, if it works for you I'll merge that here.

from openrtb.

matzi11a avatar matzi11a commented on May 8, 2024

that has resolved the issue. thanks 👍

from openrtb.

opinali avatar opinali commented on May 8, 2024

Good, merged as commit d3204c8.

from openrtb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.