Git Product home page Git Product logo

Comments (2)

scratali avatar scratali commented on May 19, 2024

Hi
I tested liquid fun in my own code. Here's my initial code:

b2ParticleGroupDef pd;
pd.flags = b2_waterParticle;
b2PolygonShape shape;
shape.SetAsBox(hx, hy, vCenter, 0.0);
pd.shape = &shape;
pWorld->CreateParticleGroup(pd);

After this, I got some like 9 or 10 memory leak reports. Using visual leak detector, I was able to track down which buffers are not freed and here's the list (which I free manually):

free(pWorld->m_particleSystem.m_flagsBuffer.data);
free(pWorld->m_particleSystem.m_positionBuffer.data);
free(pWorld->m_particleSystem.m_velocityBuffer.data);
free(pWorld->m_particleSystem.m_accumulationBuffer);
free(pWorld->m_particleSystem.m_colorBuffer.data);
free(pWorld->m_particleSystem.m_groupBuffer);
free(pWorld->m_particleSystem.m_userDataBuffer.data);
free(pWorld->m_particleSystem.m_contactBuffer);
free(pWorld->m_particleSystem.m_proxyBuffer);
free(pWorld->m_particleSystem.m_bodyContactBuffer);

All getting memory through ReallocateBuffer(). I don't know if this is a bug in ReallocateBuffer or box2d's own blockAllocator memory allocation system.

Btw, great API!

Thanks

from liquidfun.

stewartmiles avatar stewartmiles commented on May 19, 2024

This has been fixed in a couple of ways.
Firstly, we modified b2ParticleSystem to explicitly free all allocated memory. In addition, we fixed b2BlockAllocator to free anything it allocates on destruction since large blocks would be leaked.
https://github.com/google/liquidfun/releases/tag/v1.0.0

from liquidfun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.